Page MenuHomeFreeBSD

sound: Standardize mixer_init() call order
AbandonedPublic

Authored by christos on Fri, Aug 21, 12:43 PM.
Tags
None
Referenced Files
F170339159: D59072.id.diff
Fri, Sep 4, 9:01 AM
F170295307: D59072.diff
Fri, Sep 4, 4:53 AM
F170195541: D59072.diff
Thu, Sep 3, 8:00 PM
F170134865: D59072.id184638.diff
Thu, Sep 3, 3:04 PM
Unknown Object (File)
Wed, Sep 2, 6:42 PM
Unknown Object (File)
Wed, Sep 2, 4:59 AM
Unknown Object (File)
Tue, Sep 1, 8:55 PM
Unknown Object (File)
Tue, Sep 1, 12:04 PM
Subscribers

Details

Summary

Device drivers call mixer_init() in a non-standard order - some before
pcm_init(), and some after pcm_register(). However, both approaches are
potentially risky, and logically weak, since pcm_register() is supposed
to be the function that finalizes sound(4) attach.

Standardize the call ordering by moving all mixer_init() calls after
pcm_init(). This is also necessary for a follow-up patch, which expects
pcm_init() to have run first and initialized the PCM lock.

Sponsored by: The FreeBSD Foundation
MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75937
Build 72820: arc lint + arc unit