Page MenuHomeFreeBSD
Differential D58370

snd_hdspe: Avoid allocation in the interrupt handler
ClosedPublic
Actions

Authored by kbowling on Jul 21 2026, 4:17 AM.
Tags
None
Referenced Files
F174432200: D58370.id184207.diff
Sat, Oct 3, 4:18 AM
F174395016: D58370.diff
Fri, Oct 2, 9:40 PM
Unknown Object (File)
Thu, Oct 1, 6:30 PM
Unknown Object (File)
Thu, Oct 1, 2:21 PM
Unknown Object (File)
Thu, Oct 1, 10:05 AM
Unknown Object (File)
Thu, Oct 1, 1:29 AM
Unknown Object (File)
Tue, Sep 29, 2:30 PM
Unknown Object (File)
Tue, Sep 29, 6:11 AM
View All 58 Files
Subscribers
christos
imp

Details

Reviewers
br
dev_submerge.ch
Commits
rG0bc69050e40e: snd_hdspe: Avoid allocation in the interrupt handler
rG4c1004c00ff2: snd_hdspe: Avoid allocation in the interrupt handler
Summary

Cache PCM children and drain interrupt callbacks before detach

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kbowling created this revision.Jul 21 2026, 4:17 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 21 2026, 4:17 AM
kbowling requested review of this revision.Jul 21 2026, 4:17 AM
kbowling updated this revision to Diff 182351.Jul 21 2026, 4:29 AM
kbowling added a reviewer: dev_submerge.ch.Jul 28 2026, 8:05 PM
br accepted this revision.Aug 17 2026, 2:00 PM
This revision is now accepted and ready to land.Aug 17 2026, 2:00 PM
br added a comment.Aug 17 2026, 2:01 PM

Thanks. We needed that for many years as detaching was sometimes panic system:)

Closed by commit rG4c1004c00ff2: snd_hdspe: Avoid allocation in the interrupt handler (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyAug 17 2026, 5:46 PM
This revision was automatically updated to reflect the committed changes.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG4c1004c00ff2: snd_hdspe: Avoid allocation in the interrupt handler.
christos added a subscriber: christos.Aug 21 2026, 12:42 PM

Doesn't snd_hdsp(4) need the same?

kbowling added a comment.Aug 22 2026, 1:15 AM
In D58370#1354832, @christos wrote:

Doesn't snd_hdsp(4) need the same?

Done as 74db53d5d7657d0508940d1193f05a39df85434a

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG0bc69050e40e: snd_hdspe: Avoid allocation in the interrupt handler.Aug 25 2026, 12:33 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pci/
96 lines
9 lines
26 lines

Diff 184207

View Options

sys/dev/sound/pci/hdspe-pcm.c

Loading...
View Options

sys/dev/sound/pci/hdspe.h

Loading...
View Options

sys/dev/sound/pci/hdspe.c

Loading...