Differential D47156

bus_generic_detach: Remove redundant check
ClosedPublic
Actions

Authored by jhb on Oct 16 2024, 3:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jul 29, 7:49 PM

	Unknown Object (File)
	Fri, Jul 24, 1:38 PM

	Unknown Object (File)
	Fri, Jul 10, 11:47 PM

	Unknown Object (File)
	Jul 7 2026, 7:09 PM

	Unknown Object (File)
	Jun 26 2026, 3:52 PM

	Unknown Object (File)
	Jun 22 2026, 8:51 PM

	Unknown Object (File)
	Jun 20 2026, 7:43 AM

	Unknown Object (File)
	Jun 19 2026, 5:58 AM

Subscribers

Details

Reviewers

Commits

rGa52372fc472a: bus_generic_detach: Remove redundant check
rG4e3ad581b5dc: bus_generic_detach: Remove redundant check
rG3342afcbaf42: bus_generic_detach: Remove redundant check

Summary

device_detach() checks the device state and only calls a driver's
DEVICE_DETACH method if the device is attached but not busy.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 16 2024, 3:27 PM

Herald added a subscriber: olce. · View Herald TranscriptOct 16 2024, 3:27 PM

jhb requested review of this revision.Oct 16 2024, 3:27 PM

Harbormaster completed remote builds in B60043: Diff 144996.Oct 16 2024, 3:27 PM

jhb added a parent revision: D47155: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails.Oct 16 2024, 3:27 PM

jhb added a child revision: D47157: devinfo: Output device description in verbose mode.

imp accepted this revision.Oct 16 2024, 3:31 PM

This revision is now accepted and ready to land.Oct 16 2024, 3:31 PM

Closed by commit rG3342afcbaf42: bus_generic_detach: Remove redundant check (authored by jhb). · Explain WhyOct 16 2024, 6:11 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3342afcbaf42: bus_generic_detach: Remove redundant check.

jhb added a commit: rG4e3ad581b5dc: bus_generic_detach: Remove redundant check.Dec 1 2024, 4:57 AM

jhb added a commit: rGa52372fc472a: bus_generic_detach: Remove redundant check.

Revision Contents
Changeset List

Path

Size

sys/

kern/

3 lines

Diff 145007

sys/kern/subr_bus.c

Loading...