bus_generic_detach: Remove redundant check
ClosedPublic
Actions

Authored by jhb on Oct 16 2024, 3:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 12:16 AM

	Unknown Object (File)
	Thu, Nov 14, 11:39 PM

	Unknown Object (File)
	Wed, Nov 6, 4:19 PM

	Unknown Object (File)
	Wed, Nov 6, 2:30 PM

	Unknown Object (File)
	Tue, Nov 5, 7:49 PM

	Unknown Object (File)
	Tue, Oct 29, 10:53 PM

	Unknown Object (File)
	Oct 25 2024, 12:25 AM

	Unknown Object (File)
	Oct 20 2024, 9:36 PM

View All 16 Files

Subscribers

olce

Details

Reviewers

imp

Commits

rG3342afcbaf42: bus_generic_detach: Remove redundant check

Summary

device_detach() checks the device state and only calls a driver's
DEVICE_DETACH method if the device is attached but not busy.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 16 2024, 3:27 PM

Herald added a subscriber: olce. · View Herald TranscriptOct 16 2024, 3:27 PM

jhb requested review of this revision.Oct 16 2024, 3:27 PM

Harbormaster completed remote builds in B60043: Diff 144996.Oct 16 2024, 3:27 PM

jhb added a parent revision: D47155: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails.Oct 16 2024, 3:27 PM

jhb added a child revision: D47157: devinfo: Output device description in verbose mode.

imp accepted this revision.Oct 16 2024, 3:31 PM

This revision is now accepted and ready to land.Oct 16 2024, 3:31 PM

Closed by commit rG3342afcbaf42: bus_generic_detach: Remove redundant check (authored by jhb). · Explain WhyOct 16 2024, 6:11 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3342afcbaf42: bus_generic_detach: Remove redundant check.

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_bus.c

3 lines

Diff 145007

View Options

bus_generic_detach: Remove redundant checkClosedPublicActions