Differential D47222

csa: Use pci_find_device to simplify clkrun_hack
ClosedPublic
Actions

Authored by jhb on Oct 21 2024, 2:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 9, 4:02 AM

	Unknown Object (File)
	Wed, Oct 8, 3:16 PM

	Unknown Object (File)
	Wed, Oct 8, 3:11 PM

	Unknown Object (File)
	Sun, Sep 21, 5:05 PM

	Unknown Object (File)
	Fri, Sep 12, 7:41 PM

	Unknown Object (File)
	Thu, Sep 11, 5:20 PM

	Unknown Object (File)
	Thu, Sep 11, 11:29 AM

	Unknown Object (File)
	Sep 10 2025, 8:38 AM

View All 49 Files

Subscribers

None

Details

Reviewers

imp
christos

Commits

rG11592af90f0d: csa: Use pci_find_device to simplify clkrun_hack
rGb8b100db9fcb: csa: Use pci_find_device to simplify clkrun_hack
rGf0bc751d6fb4: csa: Use pci_find_device to simplify clkrun_hack

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Oct 21 2024, 2:35 PM

jhb created this revision.

Harbormaster completed remote builds in B60122: Diff 145275.Oct 21 2024, 2:35 PM

jhb added a parent revision: D47221: vf_i2c: Don't hold a mutex across bus_generic_detach.Oct 21 2024, 2:35 PM

jhb added a reviewer: christos.Oct 22 2024, 1:53 PM

LGTM, except a minor nit.

sys/dev/sound/pci/csa.c
135–138

This revision is now accepted and ready to land.Oct 22 2024, 2:52 PM

Though I like christos' cleanup

Closed by commit rGf0bc751d6fb4: csa: Use pci_find_device to simplify clkrun_hack (authored by jhb). · Explain WhyOct 24 2024, 2:24 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGf0bc751d6fb4: csa: Use pci_find_device to simplify clkrun_hack.

jhb added a commit: rGb8b100db9fcb: csa: Use pci_find_device to simplify clkrun_hack.Dec 1 2024, 4:57 AM

jhb added a commit: rG11592af90f0d: csa: Use pci_find_device to simplify clkrun_hack.

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pci/

47 lines

Diff 145429

sys/dev/sound/pci/csa.c

Loading...