Differential D35196

dumpon: warn if the configured netdump link is down
ClosedPublic
Actions

Authored by mhorne on May 13 2022, 5:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jun 19, 7:06 PM

	Unknown Object (File)
	Fri, Jun 19, 5:36 PM

	Unknown Object (File)
	Thu, Jun 4, 11:59 PM

	Unknown Object (File)
	Wed, Jun 3, 1:59 PM

	Unknown Object (File)
	May 14 2026, 10:29 AM

	Unknown Object (File)
	May 14 2026, 5:52 AM

	Unknown Object (File)
	May 14 2026, 3:55 AM

	Unknown Object (File)
	May 14 2026, 3:55 AM

Subscribers

Details

Reviewers

markj
cem

Commits

rG8fab6c484931: dumpon: warn if the configured netdump link is down
rG6543fa5a5c47: dumpon: warn if the configured netdump link is down

Summary

Previously we expected the DIOSKERNELDUMP ioctl to return ENXIO if the
interface was down, but it does not actually do this. Grab the link
status using getifaddrs(3) instead, and downgrade this case from an
error to a warning; the user might bring the link back up at a later
time.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.May 13 2022, 5:02 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 13 2022, 5:02 PM

mhorne requested review of this revision.May 13 2022, 5:02 PM

Harbormaster completed remote builds in B45566: Diff 105949.May 13 2022, 5:02 PM

Seems reasonable to me.

This revision is now accepted and ready to land.May 14 2022, 2:37 AM

Closed by commit rG6543fa5a5c47: dumpon: warn if the configured netdump link is down (authored by mhorne). · Explain WhyMay 14 2022, 1:28 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG6543fa5a5c47: dumpon: warn if the configured netdump link is down.

mhorne added a commit: rG8fab6c484931: dumpon: warn if the configured netdump link is down.May 27 2022, 4:24 PM

Revision Contents
Changeset List

Path

Size

sbin/

dumpon/

27 lines

Diff 105996

sbin/dumpon/dumpon.c

Loading...