Page MenuHomeFreeBSD
Feed Advanced Search

Today

cem added a comment to D19996: List-ify kernel dump device configuration.

Thanks for taking a look!

Tue, Apr 23, 1:47 AM
cem created D20019: x86: Halt non-BSP CPUs on panic IPI_STOP.
Tue, Apr 23, 12:34 AM

Yesterday

cem added inline comments to D20007: ar: shuffle symbol offsets during conversion for 32-bit ar archives.
Mon, Apr 22, 7:22 PM
cem committed rS346566: random.3: Remove obsolete BUGS section.
random.3: Remove obsolete BUGS section
Mon, Apr 22, 4:29 PM
cem committed rS346565: rand.3: Match better recommendation language from random.3.
rand.3: Match better recommendation language from random.3
Mon, Apr 22, 4:27 PM
cem added a child revision for D19948: Add witness(4) warnings around potentially blocking requests for random: D20011: ip6_randomflowlabel: Avoid blocking if random(4) is not available.
Mon, Apr 22, 4:19 PM
cem added a parent revision for D20011: ip6_randomflowlabel: Avoid blocking if random(4) is not available: D19948: Add witness(4) warnings around potentially blocking requests for random.
Mon, Apr 22, 4:19 PM
cem added a child revision for D20011: ip6_randomflowlabel: Avoid blocking if random(4) is not available: D19973: ip6_id: Avoid blocking if random(4) is not available.
Mon, Apr 22, 4:18 PM
cem added a parent revision for D19973: ip6_id: Avoid blocking if random(4) is not available: D20011: ip6_randomflowlabel: Avoid blocking if random(4) is not available.
Mon, Apr 22, 4:18 PM
cem created D20011: ip6_randomflowlabel: Avoid blocking if random(4) is not available.
Mon, Apr 22, 4:17 PM
cem added a comment to D20005: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.
In D20005#429915, @ngie wrote:

Thanks for the better fix. BTW, I still think these checks would be better to be rewritten as getting the real number and compare with 65535.

Totally agree, but I couldn't get clarity on whether or not the value could be static or how to compute it. I'll see if I can reverse engineer how sometime in the future (*files bug*).

Mon, Apr 22, 3:57 PM
cem added a comment to D19754: cxgbe(4): Integrate with PNP PCIID-based autoload.
In D19754#429906, @ae wrote:

We have single machine, that after automatic firmware upgrade fails to attache the driver:
...
So, it can be dangerous...

Mon, Apr 22, 3:50 PM
cem committed rS346516: gnop(8): Nopify configuration as a kernel dump device.
gnop(8): Nopify configuration as a kernel dump device
Mon, Apr 22, 3:26 AM
cem closed D19991: gnop(8): Nopify configuration as a kernel dump device.
Mon, Apr 22, 3:26 AM
cem updated subscribers of D19996: List-ify kernel dump device configuration.
Mon, Apr 22, 1:57 AM
cem added inline comments to D19991: gnop(8): Nopify configuration as a kernel dump device.
Mon, Apr 22, 1:56 AM

Sun, Apr 21

cem added a comment to D19973: ip6_id: Avoid blocking if random(4) is not available.
In D19973#429780, @bz wrote:
In D19973#429776, @cem wrote:

This function is also used for non-flowid number generation; I’m not sure if those can be zero early on.

What else are we looking at? Your initial description describes the problem but not really what all is affected?

Sun, Apr 21, 10:33 PM
cem added a comment to D19973: ip6_id: Avoid blocking if random(4) is not available.
In D19973#429748, @thj wrote:

I think we can just use zero for the label if enough entropy is not available. A flow label of zero indicates no flow label "treatment" in the network.

Sun, Apr 21, 9:22 PM
cem added inline comments to D19928: random(4): More thoroughly attempt to ensure seeding during priming.
Sun, Apr 21, 6:20 PM
cem created D19996: List-ify kernel dump device configuration.
Sun, Apr 21, 5:21 PM
cem added a comment to D19991: gnop(8): Nopify configuration as a kernel dump device.

I'm just thinking in terms of reducing binary size on normal builds. This doesn't have any uses on a normal system, does it?

Sun, Apr 21, 4:03 PM
cem added a comment to D19991: gnop(8): Nopify configuration as a kernel dump device.

Since this is just for development, should it be guarded by #ifdef INVARIANTS?

Sun, Apr 21, 12:17 AM

Sat, Apr 20

cem created D19991: gnop(8): Nopify configuration as a kernel dump device.
Sat, Apr 20, 7:54 PM
cem added a comment to D19973: ip6_id: Avoid blocking if random(4) is not available.
In D19973#429484, @bz wrote:

Is there a notification for when we are fully seeded the first time and entropy is available?

Sat, Apr 20, 4:17 PM
cem committed rS346448: netdump: Fix 11 compatibility DIOCSKERNELDUMP ioctl.
netdump: Fix 11 compatibility DIOCSKERNELDUMP ioctl
Sat, Apr 20, 4:07 PM
cem closed D19980: netdump: Fix 11 compatibility DIOCSKERNELDUMP ioctl.
Sat, Apr 20, 4:07 PM
cem created D19980: netdump: Fix 11 compatibility DIOCSKERNELDUMP ioctl.
Sat, Apr 20, 3:25 AM
cem added inline comments to D19973: ip6_id: Avoid blocking if random(4) is not available.
Sat, Apr 20, 12:24 AM
cem added inline comments to D19928: random(4): More thoroughly attempt to ensure seeding during priming.
Sat, Apr 20, 12:22 AM

Fri, Apr 19

cem added a comment to D19978: Test the AES-CCM test vectors from the NIST Known Answer Tests..

Hm, why isn't maclen of 16 an issue for encrypt?

Fri, Apr 19, 10:27 PM
cem accepted D19977: Use more descriptive algorithm names in skip messages..

No objection, although it's somewhat moot because the lists are shared (aesmodules, shamodules). Unless you plan to change that.

Fri, Apr 19, 10:17 PM
cem committed rS346420: Revert r346410 and r346411.
Revert r346410 and r346411
Fri, Apr 19, 10:08 PM
cem added a comment to D19948: Add witness(4) warnings around potentially blocking requests for random.

Let me make sure I understand the concern correctly.

Fri, Apr 19, 9:51 PM
cem added a comment to D19972: in_pcb_lport: Don't attempt to randomize if random(4) is unavailable.
In D19972#429343, @jhb wrote:

Is this a case where 'not very random' PRNG output is still better than "sequential port assignment"? That is, if we had a variant of arc4random() that would fail to "weak output" rather than blocking?

Fri, Apr 19, 9:39 PM
cem committed rS346412: kernel build: Disable unhelpful GCC warning (tripped after r346352).
kernel build: Disable unhelpful GCC warning (tripped after r346352)
Fri, Apr 19, 8:08 PM
cem committed rS346411: Bump __FreeBSD_version after r346410.
Bump __FreeBSD_version after r346410
Fri, Apr 19, 8:06 PM
cem committed rS346410: libkern: Bring in arc4random_uniform(9) from libc.
libkern: Bring in arc4random_uniform(9) from libc
Fri, Apr 19, 8:06 PM
cem added a child revision for D19948: Add witness(4) warnings around potentially blocking requests for random: D19973: ip6_id: Avoid blocking if random(4) is not available.
Fri, Apr 19, 7:58 PM
cem added a parent revision for D19973: ip6_id: Avoid blocking if random(4) is not available: D19948: Add witness(4) warnings around potentially blocking requests for random.
Fri, Apr 19, 7:57 PM
cem created D19973: ip6_id: Avoid blocking if random(4) is not available.
Fri, Apr 19, 7:57 PM
cem updated the diff for D19972: in_pcb_lport: Don't attempt to randomize if random(4) is unavailable.

Remove arc misfire

Fri, Apr 19, 7:35 PM
cem added inline comments to D19972: in_pcb_lport: Don't attempt to randomize if random(4) is unavailable.
Fri, Apr 19, 7:32 PM
cem added a child revision for D19948: Add witness(4) warnings around potentially blocking requests for random: D19972: in_pcb_lport: Don't attempt to randomize if random(4) is unavailable.
Fri, Apr 19, 7:32 PM
cem added a parent revision for D19972: in_pcb_lport: Don't attempt to randomize if random(4) is unavailable: D19948: Add witness(4) warnings around potentially blocking requests for random.
Fri, Apr 19, 7:32 PM
cem created D19972: in_pcb_lport: Don't attempt to randomize if random(4) is unavailable.
Fri, Apr 19, 7:31 PM
cem committed rS346399: random.4: Include description of knobs added in r346358.
random.4: Include description of knobs added in r346358
Fri, Apr 19, 5:16 PM
cem committed rS346364: Update to Zstandard 1.4.0.
Update to Zstandard 1.4.0
Fri, Apr 19, 2:54 AM
cem committed rS346362: tag zstd 1.4.0.
tag zstd 1.4.0
Fri, Apr 19, 12:32 AM
cem committed rS346361: import zstd 1.4.0.
import zstd 1.4.0
Fri, Apr 19, 12:31 AM

Thu, Apr 18

cem committed rS346358: random(4): Restore availability tradeoff prior to r346250.
random(4): Restore availability tradeoff prior to r346250
Thu, Apr 18, 8:49 PM
cem closed D19944: random(4): Restore availability tradeoff prior to r346250.
Thu, Apr 18, 8:49 PM
cem added a comment to D19944: random(4): Restore availability tradeoff prior to r346250.

Thanks Xin and Warner!

Thu, Apr 18, 5:27 PM
cem updated the diff for D19944: random(4): Restore availability tradeoff prior to r346250.
  • Incorporate Ravi's suggested description wording
  • Incorporate a SHA256 version of Xin's suggestion for fallback arc4random seeding for reasons mentioned in differential (open to discussion, just presenting a prototype)
Thu, Apr 18, 5:26 PM
cem planned changes to D19944: random(4): Restore availability tradeoff prior to r346250.
Thu, Apr 18, 5:13 PM
cem added a comment to D19944: random(4): Restore availability tradeoff prior to r346250.

Thanks markm and imp.

Thu, Apr 18, 4:49 PM
cem added reviewers for D19948: Add witness(4) warnings around potentially blocking requests for random: emaste, imp, delphij.
Thu, Apr 18, 12:32 AM
cem added a child revision for D19944: random(4): Restore availability tradeoff prior to r346250: D19948: Add witness(4) warnings around potentially blocking requests for random.
Thu, Apr 18, 12:32 AM
cem added a parent revision for D19948: Add witness(4) warnings around potentially blocking requests for random: D19944: random(4): Restore availability tradeoff prior to r346250.
Thu, Apr 18, 12:32 AM
cem updated the test plan for D19948: Add witness(4) warnings around potentially blocking requests for random.
Thu, Apr 18, 12:30 AM
cem updated the diff for D19948: Add witness(4) warnings around potentially blocking requests for random.

Yeah, moving the check into arc4rand helps.

Thu, Apr 18, 12:26 AM
cem created D19948: Add witness(4) warnings around potentially blocking requests for random.
Thu, Apr 18, 12:21 AM
cem added inline comments to D19928: random(4): More thoroughly attempt to ensure seeding during priming.
Thu, Apr 18, 12:01 AM

Wed, Apr 17

cem added a comment to D19944: random(4): Restore availability tradeoff prior to r346250.

Thanks, @adrian and @delphij!

Wed, Apr 17, 11:50 PM
cem added inline comments to D19944: random(4): Restore availability tradeoff prior to r346250.
Wed, Apr 17, 10:54 PM
cem added inline comments to D19944: random(4): Restore availability tradeoff prior to r346250.
Wed, Apr 17, 10:08 PM
cem updated the diff for D19944: random(4): Restore availability tradeoff prior to r346250.

At suggestion of rpokala@ and with help from np@, incorporate MD cyclecounter
in fako arc4random seeding when devrandom is bypassed unseeded.

Wed, Apr 17, 10:05 PM
cem added a child revision for D19944: random(4): Restore availability tradeoff prior to r346250: D19928: random(4): More thoroughly attempt to ensure seeding during priming.
Wed, Apr 17, 7:57 PM
cem added a parent revision for D19928: random(4): More thoroughly attempt to ensure seeding during priming: D19944: random(4): Restore availability tradeoff prior to r346250.
Wed, Apr 17, 7:57 PM
cem created D19944: random(4): Restore availability tradeoff prior to r346250.
Wed, Apr 17, 7:56 PM
cem added a comment to D19928: random(4): More thoroughly attempt to ensure seeding during priming.
In D19928#428534, @imp wrote:

I like that we can have a fallback seeding to RND devices, but Netflix requires a system to be bootable to userland no matter what goes on with the randomness in early boot. As such, we'd like a mode that can report that something screwed up in the early random stuff so we can decide if we care or not about that.

Wed, Apr 17, 6:17 PM

Tue, Apr 16

cem added a comment to D19928: random(4): More thoroughly attempt to ensure seeding during priming.

Thanks for taking a look!

Tue, Apr 16, 9:06 PM
cem committed rS346292: stack_protector: Add tunable to bypass random cookies.
stack_protector: Add tunable to bypass random cookies
Tue, Apr 16, 6:47 PM
cem closed D19927: stack_protector: Add tunable to bypass random cookies.
Tue, Apr 16, 6:47 PM
cem updated the test plan for D19928: random(4): More thoroughly attempt to ensure seeding during priming.
Tue, Apr 16, 6:40 PM
cem added a reviewer for D19928: random(4): More thoroughly attempt to ensure seeding during priming: cperciva.
Tue, Apr 16, 6:39 PM
cem updated the diff for D19928: random(4): More thoroughly attempt to ensure seeding during priming.

Shuffle ordering of pure random source registration from late in autoconfig
(SI_SUB_DRIVERS) up to SI_SUB_RANDOM, and correctly invoke ra_pre_read in order
to actually transition an algorithm from !seeded to seeded (otherwise, all the
entropy in the world will not change that status).

Tue, Apr 16, 6:37 PM
cem added a comment to D19927: stack_protector: Add tunable to bypass random cookies.

Tinderbox passes. I'd appreciate expediency on this one, if possible.

Tue, Apr 16, 6:00 PM
cem created D19928: random(4): More thoroughly attempt to ensure seeding during priming.
Tue, Apr 16, 5:40 PM
cem updated the diff for D19927: stack_protector: Add tunable to bypass random cookies.

Add CTASSERT that nitems(__stack_chk_guard) matches our expectations.

Tue, Apr 16, 5:16 PM
cem added a reviewer for D19927: stack_protector: Add tunable to bypass random cookies: imp.
Tue, Apr 16, 5:12 PM
cem closed D19926: random(4): Add is_random_seeded(9) KPI.
Tue, Apr 16, 5:12 PM
cem committed rS346282: random(4): Add is_random_seeded(9) KPI.
random(4): Add is_random_seeded(9) KPI
Tue, Apr 16, 5:12 PM
cem updated the diff for D19926: random(4): Add is_random_seeded(9) KPI.

document in random.9 and add link

Tue, Apr 16, 5:10 PM
cem created D19927: stack_protector: Add tunable to bypass random cookies.
Tue, Apr 16, 5:02 PM
cem updated the test plan for D19926: random(4): Add is_random_seeded(9) KPI.
Tue, Apr 16, 4:51 PM
cem planned changes to D19926: random(4): Add is_random_seeded(9) KPI.

Ah, this deserves a manual page link to random.9 and random.9 update.

Tue, Apr 16, 4:34 PM
cem created D19926: random(4): Add is_random_seeded(9) KPI.
Tue, Apr 16, 4:24 PM
cem updated the diff for D19918: sys: Remove DEV_RANDOM device option.

Rebase on WIP changes; no functional change.

Tue, Apr 16, 4:22 PM
cem updated subscribers of D19918: sys: Remove DEV_RANDOM device option.

I'm in favor of this change; please consider this as an explicit "accepted" if nobody objects in a week.

Tue, Apr 16, 2:56 PM

Mon, Apr 15

cem created D19918: sys: Remove DEV_RANDOM device option.
Mon, Apr 15, 8:46 PM
cem committed rS346251: random.3: Clarify confusing summary.
random.3: Clarify confusing summary
Mon, Apr 15, 6:49 PM
cem committed rS346250: random(4): Block read_random(9) on initial seeding.
random(4): Block read_random(9) on initial seeding
Mon, Apr 15, 6:40 PM
cem closed D19744: random(4): Block read_random(9) on initial seeding.
Mon, Apr 15, 6:40 PM
cem added inline comments to D19744: random(4): Block read_random(9) on initial seeding.
Mon, Apr 15, 5:30 PM

Sun, Apr 14

cem updated the diff for D19744: random(4): Block read_random(9) on initial seeding.
  • Replace slpflags parameter to wait_until_seeded with boolean parameter. I still prefer a named parameter at consumers, so I made some file-local defines for true and false that show intent more clearly (I hope).
  • Dropped panic() from !DEV_RANDOM empty read_random implementation. We will address !DEV_RANDOM separately.
  • Added sysctl/tunable to enable testing of unavailability of random device throughout early boot, and documented it in random.4.
  • Bumped .Dd on manual pages.
Sun, Apr 14, 7:01 PM

Sat, Apr 13

cem committed rS346187: hexdump(1): Exit gracefully on format strings missing conversion.
hexdump(1): Exit gracefully on format strings missing conversion
Sat, Apr 13, 4:52 PM
cem committed rS346175: sort(1): Memoize MD5 computation to reduce repeated computation.
sort(1): Memoize MD5 computation to reduce repeated computation
Sat, Apr 13, 4:42 AM
cem closed D19885: sort(1): Memoize MD5 computation to reduce repeated computation.
Sat, Apr 13, 4:42 AM
cem accepted D19651: Add a fusefs(5) man page.
Sat, Apr 13, 4:41 AM

Fri, Apr 12

cem added inline comments to D19885: sort(1): Memoize MD5 computation to reduce repeated computation.
Fri, Apr 12, 7:07 PM