Page MenuHomeFreeBSD
Feed Advanced Search

Today

D20988: Provide new tunable hw.nvme.verbose_cmd_dump is now accepted and ready to land.

LGTM, thanks.

Fri, Jul 19, 12:15 AM

Yesterday

cem accepted D20988: Provide new tunable hw.nvme.verbose_cmd_dump.
Thu, Jul 18, 10:27 PM
D20969: Add option to set umask before starting child process is now accepted and ready to land.
Thu, Jul 18, 6:48 PM
D20969: Add option to set umask before starting child process is now accepted and ready to land.
Thu, Jul 18, 5:20 AM

Tue, Jul 16

cem added a comment to D20892: Add support for PCI Device ID 0x148B in ntb_hw_amd driver.

@cem, sorry about the delayed response.
I was trying to use the "arc" tool for updating the patch. But it asks to create a new commit as below. I am unsure whether to accept it.

Tue, Jul 16, 4:22 PM

Mon, Jul 15

D20964: Fix two mismatches between function declaration and definition. is now accepted and ready to land.

I'd just drop the extra * on the other of the definition/declaration, but I don't know if we have a style(9) preference. Functionally / semantically it looks good.

Mon, Jul 15, 10:49 PM

Tue, Jul 9

cem added a comment to D20892: Add support for PCI Device ID 0x148B in ntb_hw_amd driver.

The general idea of the change looks good to me, thanks!

Tue, Jul 9, 5:56 PM
D20894: Correct definitions in sys.opencrypto.runtests.main for 32bit platform is now accepted and ready to land.

No objection.

Tue, Jul 9, 4:58 PM
cem added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

Thanks @mav for reviewing and pushing the patch upstream. I verified it to work properly. I have some more minor changes to this Driver (basically to add support for another PCI Device ID). Shall I submit the additional patch here itself? or should I open another review for the same?

Tue, Jul 9, 1:24 PM
D20764: Allow limiting the size of syslogd output files using options in syslog.conf now requires changes to proceed.

FWIW, I also work on an embedded appliance.

Tue, Jul 9, 6:08 AM

Mon, Jul 8

cem added a comment to D20877: Ignore kern.vt.splash_cpu on bhyve.

I would change the commit summary/title, though. Really we're just disabling a feature when it is unsupported by some particular configuration; it's not bhyve-specific.

Mon, Jul 8, 5:58 AM
D20877: Ignore kern.vt.splash_cpu on bhyve is now accepted and ready to land.
Mon, Jul 8, 5:57 AM

Sun, Jul 7

D20876: Limit access to system accounting files is now accepted and ready to land.

Looks good to me.

Sun, Jul 7, 6:41 PM
cem added inline comments to D20876: Limit access to system accounting files.
Sun, Jul 7, 6:10 PM
D20871: Fix comment after r349791 is now accepted and ready to land.

Thanks!

Sun, Jul 7, 6:44 AM

Sat, Jul 6

cem added inline comments to D20847: fix style(9) violations involving division by PAGE_SIZE.
Sat, Jul 6, 10:15 PM
cem added inline comments to D20847: fix style(9) violations involving division by PAGE_SIZE.
Sat, Jul 6, 5:02 PM

Wed, Jul 3

cem added a comment to D20842: Bug 238960: panic in vm_pageout_collect_batch() with QUEUE_MACRO_DEBUG_TRASH enabled.

LGTM. For future reference, please upload patches with more context. That could mean using the arc command line tool, which simplifies the process somewhat once it is set up, or diff -U99999 if you prefer not to use the arc ("Arcanist") tool.

Wed, Jul 3, 4:23 PM
cem added inline comments to D19495: bhyve - Snapshot Save and Restore.
Wed, Jul 3, 7:45 AM · bhyve

Fri, Jun 28

cem added a comment to D20324: Introduce the ARB tree(3) macros.

But I've added the justification (explanation of what's the point of ARB, from the consumer point of view) to the man page already. What else is needed?

Fri, Jun 28, 12:45 PM

Thu, Jun 27

cem added inline comments to D20780: Add support for getting early entropy from the UEFI RNG protocol.
Thu, Jun 27, 7:16 PM · security, arm64
cem updated subscribers of D20780: Add support for getting early entropy from the UEFI RNG protocol.
Thu, Jun 27, 3:01 PM · security, arm64

Wed, Jun 26

cem added a comment to D20116: Introduce <sys/qmath.h>.
In D20116#448878, @cem wrote:

I think there are open questions around rounding behavior and making the extensive macros into functions.

The problem with functions is that in many places it uses Q_TC() (which boils down to __typeof()), or macros that expand to Q_TC(). I guess I could try to rework the ones which don't, but that would look inconsistent.

Wed, Jun 26, 6:24 AM
D20324: Introduce the ARB tree(3) macros now requires changes to proceed.

So... is there anything else left to do here?

Wed, Jun 26, 6:15 AM
cem updated subscribers of D20764: Allow limiting the size of syslogd output files using options in syslog.conf.
Wed, Jun 26, 5:50 AM
cem added a comment to D20764: Allow limiting the size of syslogd output files using options in syslog.conf.

The design seems kind of poor (random last 32k corruption?). Alternatively / relatedly, we (ISLN) have a syslogd patch we can share that parses newsyslogd.conf and manually invokes newsyslogd directly when logs grow beyond configured rotation size.

Wed, Jun 26, 5:49 AM

Tue, Jun 25

D20116: Introduce <sys/qmath.h> now requires changes to proceed.

So... is there anything else left for me to do here before this can get committed?

Tue, Jun 25, 3:43 PM

Mon, Jun 24

cem accepted D20743: g_eli_create: only dec g_access acw if we inc'd it.
Mon, Jun 24, 5:09 PM
cem accepted D20742: netipsec key_register: check for M_NOWAIT alloc failure.
Mon, Jun 24, 5:07 PM
cem added a comment to D20721: motd: Generate from template to /var/run.

Thanks, Benedict!

Mon, Jun 24, 4:01 PM

Fri, Jun 21

cem added a comment to D20721: motd: Generate from template to /var/run.
  • Fix a typo in rc.d/motd
  • Update login(1) and motd.5
Fri, Jun 21, 11:37 PM
cem created D20721: motd: Generate from template to /var/run.
Fri, Jun 21, 11:27 PM
cem accepted D20703: VirtIO SCSI: validate seg_max from hypervisor.
Fri, Jun 21, 10:49 PM
cem committed rS349256: rc.d/motd: Update motd more robustly.
rc.d/motd: Update motd more robustly
Fri, Jun 21, 2:38 AM
cem closed D20701: rc.d/motd: Update motd more robustly.
Fri, Jun 21, 2:38 AM
cem committed rS349254: Fixup UPDATING text for r349253.
Fixup UPDATING text for r349253
Fri, Jun 21, 12:33 AM
D20715: Reduce namespace pollution from r349233 is now accepted and ready to land.

Thanks!

Fri, Jun 21, 12:25 AM
Herald added a reviewer for D19918: sys: Remove DEV_RANDOM device option: manpages.
Fri, Jun 21, 12:17 AM
cem committed rS349253: sys: Remove DEV_RANDOM device option.
sys: Remove DEV_RANDOM device option
Fri, Jun 21, 12:16 AM

Thu, Jun 20

cem added a comment to D20710: fcntl: fix overflow when setting F_READAHEAD.

Wrap in vfs_vnops.c at line 502. Currently, the largest possible overflow is about 2x. So using an int16_t makes it safe.

Thu, Jun 20, 11:45 PM
cem added a comment to D20710: fcntl: fix overflow when setting F_READAHEAD.

FYI, I discovered that f_seqcount needs to be int16_t rather than int8_t in order to detect an overflow. Otherwise the slightest overflow of IO_SEQMAX will wrap.

Thu, Jun 20, 11:35 PM
D20710: fcntl: fix overflow when setting F_READAHEAD is now accepted and ready to land.

Thanks!

Thu, Jun 20, 10:38 PM
cem added a comment to D20710: fcntl: fix overflow when setting F_READAHEAD.

Need to change fifofs to actually use f_pipegen instead of f_seqcount :)

Thu, Jun 20, 10:09 PM
cem added inline comments to D19918: sys: Remove DEV_RANDOM device option.
Thu, Jun 20, 8:56 PM
D19918: sys: Remove DEV_RANDOM device option now requires review to proceed.

Rebase on recent HEAD

Thu, Jun 20, 8:52 PM
cem created P271 (An Untitled Masterwork).
Thu, Jun 20, 8:51 PM
cem added a comment to D20710: fcntl: fix overflow when setting F_READAHEAD.

Actually, I don't think the usage in fifo_vnops.c is a potential overflow. AFAICT fifos use that field for a completely different purpose. It really should be a different field (and in fact, it used to be). See r238936.

Thu, Jun 20, 6:19 PM
cem added a comment to D20710: fcntl: fix overflow when setting F_READAHEAD.

Also: nice find! :)

Thu, Jun 20, 3:43 PM
cem added a comment to D20710: fcntl: fix overflow when setting F_READAHEAD.

Looks like you could get a similar overflow by having 64k readers on a pipe too (fs/fifofs/fifo_vnops.c). You could also overflow in sequential_heuristic() if uio_resid is big enough (especially with a narrower f_seqcount).

Thu, Jun 20, 3:43 PM
cem added inline comments to D20705: Add FIOBMAP2 ioctl.
Thu, Jun 20, 3:28 PM
cem added inline comments to D20697: NTB Perf.
Thu, Jun 20, 3:24 PM
cem added inline comments to D20697: NTB Perf.
Thu, Jun 20, 5:55 AM
cem added a reviewer for D20705: Add FIOBMAP2 ioctl: mckusick.

Adding Kirk for UFS change.

Thu, Jun 20, 1:39 AM
cem added a comment to D20705: Add FIOBMAP2 ioctl.

Ah, I was thinking of FIEMAP I think. So the better question might be, why not add FIEMAP instead? https://www.kernel.org/doc/Documentation/filesystems/fiemap.txt

Thu, Jun 20, 1:38 AM
cem added a comment to D19918: sys: Remove DEV_RANDOM device option.

Hi @delphij , @markm . Is this still something that seems reasonable or should I drop it?

Thu, Jun 20, 12:40 AM
cem added a comment to D20705: Add FIOBMAP2 ioctl.

The name, etc, beg the question: what's the motivation to differ from FIOBMAP in Linux (or NetBSD)?

Thu, Jun 20, 12:36 AM

Wed, Jun 19

D20703: VirtIO SCSI: validate seg_max from hypervisor is now accepted and ready to land.
Wed, Jun 19, 9:40 PM
D20701: rc.d/motd: Update motd more robustly now requires review to proceed.

As mjg@ points out, the mktemp file may be on a different filesystem than /etc
(e.g., tmpfs, but any other filesystem invalidates the initial fsync). Copy to
a temporary /etc file, sync that, then rename over /etc/motd.

Wed, Jun 19, 8:21 PM
cem created D20701: rc.d/motd: Update motd more robustly.
Wed, Jun 19, 8:06 PM
cem added inline comments to D20697: NTB Perf.
Wed, Jun 19, 5:56 PM
cem added a comment to D20458: first step towards enforcing must-succeed semantics for bus accessors.
In D20458#447283, @avg wrote:

I encountered a technical problem trying to replace the printf with KASSERT.
bus.h does not include systm.h and there are multiple places where bus.h is included before systm.h (or systm.h not included at all).

Wed, Jun 19, 5:28 PM

Jun 18 2019

cem committed rS349176: random(4): Fix a regression in short AES mode reads.
random(4): Fix a regression in short AES mode reads
Jun 18 2019, 6:51 PM
Owners added a reviewer for D20686: random(4): Fix a regression in short AES mode reads: O3: Kernel Random Numbers Generator.
Jun 18 2019, 6:51 PM
cem updated subscribers of D20686: random(4): Fix a regression in short AES mode reads.
Jun 18 2019, 6:42 PM
cem added a reviewer for D20686: random(4): Fix a regression in short AES mode reads: secteam.
Jun 18 2019, 6:39 PM
cem created D20686: random(4): Fix a regression in short AES mode reads.
Jun 18 2019, 6:35 PM

Jun 17 2019

cem committed rS349154: random(4): Fortuna: allow increased concurrency.
random(4): Fortuna: allow increased concurrency
Jun 17 2019, 8:29 PM
Owners added a reviewer for D20313: Fortuna: allow increased concurrency: O3: Kernel Random Numbers Generator.
Jun 17 2019, 8:29 PM
D20313: Fortuna: allow increased concurrency now requires review to proceed.

Rename uint128_add to the more appropriate uint128_add64

Jun 17 2019, 7:00 PM
cem added inline comments to D20313: Fortuna: allow increased concurrency.
Jun 17 2019, 6:05 PM
D20673: Make RFB_ENCODING_ZLIB message handling idempotent. is now accepted and ready to land.

As a first-cut workaround, LGTM.

Jun 17 2019, 3:39 PM
cem accepted D20671: Add missing words and word smith in pci(4).
Jun 17 2019, 3:27 PM
cem committed rS349138: random(4): Generalize algorithm-independent APIs.
random(4): Generalize algorithm-independent APIs
Jun 17 2019, 3:09 PM
Owners added a reviewer for D20312: random(4): Generalize algorithm-independent APIs: O3: Kernel Random Numbers Generator.
Jun 17 2019, 3:09 PM
Owners added a reviewer for D20392: random(4): Add regression tests for uint128 implementation, Chacha CTR: O3: Kernel Random Numbers Generator.
Jun 17 2019, 3:00 PM
cem committed rS349137: random(4): Add regression tests for uint128 implementation, Chacha CTR.
random(4): Add regression tests for uint128 implementation, Chacha CTR
Jun 17 2019, 3:00 PM
cem added a comment to D20392: random(4): Add regression tests for uint128 implementation, Chacha CTR.

Thanks!

Jun 17 2019, 2:56 PM

Jun 15 2019

cem added inline comments to D19016: Replace strlen with strnlen..
Jun 15 2019, 9:20 PM
cem accepted D20637: Unnecessary Include Header Removal.

(<sys/param.h> includes <sys/types.h>; do not include both.)

Jun 15 2019, 12:43 AM

Jun 14 2019

cem accepted D20641: open(2): fix the description of O_FSYNC.
Jun 14 2019, 8:12 PM

Jun 13 2019

cem added a comment to D20116: Introduce <sys/qmath.h>.

Regarding the LUT idea - it does make sense, but I believe it would require somewhat complicated code surgery, and I'd rather not do it at this time: it's a vendor code which I'm trying to upstream, not to rewrite. It also sounds like something that can be done later, if neccessary.

Jun 13 2019, 8:02 PM

Jun 10 2019

cem added a comment to D20596: Document sysctl nodes that translate their values..

(bump .Dd if needed)

Jun 10 2019, 11:03 PM
cem accepted D20596: Document sysctl nodes that translate their values..
Jun 10 2019, 11:02 PM
cem accepted D20555: Make the warning intervals for deprecated crypto algorithms tunable..
Jun 10 2019, 11:01 PM
cem added a comment to D20116: Introduce <sys/qmath.h>.

Thanks for splitting up the pages.

Jun 10 2019, 7:29 PM
cem committed rS348854: /etc/rc.d/local: Fix typo in description.
/etc/rc.d/local: Fix typo in description
Jun 10 2019, 1:34 PM

Jun 9 2019

cem added inline comments to D20116: Introduce <sys/qmath.h>.
Jun 9 2019, 10:03 PM

Jun 8 2019

cem accepted D20555: Make the warning intervals for deprecated crypto algorithms tunable..
Jun 8 2019, 4:15 AM

Jun 7 2019

cem added a comment to D20312: random(4): Generalize algorithm-independent APIs.

For the microoptimization: Note that it's possible to avoid the additional branching by doing unlock in both cases, e.g.:

Jun 7 2019, 10:22 PM
cem updated the diff for D20313: Fortuna: allow increased concurrency.

Rebase on D20312 changes

Jun 7 2019, 9:38 PM
cem added a comment to D20392: random(4): Add regression tests for uint128 implementation, Chacha CTR.

@delphij , this one technically touches sys/dev/random (fix a declaration name typo but mostly add #ifndef _KERNEL compatibility shims), so I need secteam blessing to commit. I'd appreciate a look when you get a chance.

Jun 7 2019, 9:37 PM
cem updated the diff for D20312: random(4): Generalize algorithm-independent APIs.
  • Drop DELAY() entirely
  • Minor optimization: drop global lock over 1-15 bytes of memcpy and 16 bytes explicit_bzero.
Jun 7 2019, 9:34 PM
cem accepted D20554: Add warnings to /dev/crypto for deprecated algorithms..
Jun 7 2019, 9:32 PM
cem accepted D20343: Add warnings for Kerberos GSS algorithms deprecated in RFCs 6649 and 8429..
Jun 7 2019, 9:31 PM
cem added inline comments to D20312: random(4): Generalize algorithm-independent APIs.
Jun 7 2019, 9:20 PM
cem retitled D20313: Fortuna: allow increased concurrency from EXPERIMENTAL Fortuna: allow increased concurrency to Fortuna: allow increased concurrency.
Jun 7 2019, 8:35 PM
cem updated the diff for D20313: Fortuna: allow increased concurrency.
  • Rebase on newer version of D20312
  • Refactor somewhat to improve clarity
  • Continue to artificially limit lock hold duration to 4kB in "locked" == "!concurrent" mode
  • Continue to rekey AES at 1MB intervals
Jun 7 2019, 8:33 PM
cem updated the diff for D20312: random(4): Generalize algorithm-independent APIs.

Replace tsleep with DELAY().

Jun 7 2019, 8:27 PM
cem added inline comments to D20312: random(4): Generalize algorithm-independent APIs.
Jun 7 2019, 8:22 PM
cem added a comment to D20116: Introduce <sys/qmath.h>.
In D20116#443270, @sef wrote:

the man page is exceedingly complicated

Jun 7 2019, 3:14 PM