Page MenuHomeFreeBSD

debugnet: remove spurious message on boot
ClosedPublic

Authored by franco_opnsense.org on Feb 28 2022, 11:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 23, 1:57 PM
Unknown Object (File)
Mon, Jan 9, 6:01 AM
Unknown Object (File)
Mon, Jan 9, 5:19 AM
Unknown Object (File)
Sun, Jan 8, 8:23 AM
Unknown Object (File)
Mon, Jan 2, 9:59 AM
Unknown Object (File)
Dec 16 2022, 4:03 PM
Unknown Object (File)
Dec 14 2022, 2:58 AM
Unknown Object (File)
Dec 10 2022, 2:47 AM

Details

Summary

In 2019 it was said to be added to fix the drivers but that has not
happened so it does not make sense to present a non-error to users.

No response on recent mailing list question:

https://lists.freebsd.org/archives/freebsd-net/2022-February/001254.html

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think it's important to leave this sort of message in for kernel developers to see, but agreed it has little user-facing value. What about something like this:

#ifndef INVARIANTS
if (bootverbose)
#endif
	printf("%s: Bad dn_init result from %s (ifp %p), ignoring.\n",
	    __func__, if_name(ifp), ifp);

i.e., always print it in an INVARIANTS kernel, otherwise hide it under bootverbose

Either way seems fine to me. I’d ask vangyzen or bdrewery for input.

This revision is now accepted and ready to land.Feb 28 2022, 8:14 PM

Since I don't have a commit bit... anyone willing to commit this? Thanks in advance.

This revision was automatically updated to reflect the committed changes.