Page MenuHomeFreeBSD
Differential D46989

sys: Add an SMCCC Random Number Generator driver
AcceptedPublic
Actions

Authored by andrew on Mon, Oct 7, 4:54 PM.

Details

Reviewers
markm
Group Reviewers
arm64
csprng
Summary

The Arm True Random Number Generator Firmware Interface provides a way
to query the SMCCC firmware for up to 192 bits of entropy. Use it to
provide another source of randomness to the kernel.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59818
Build 56703: arc lint + arc unit

Event Timeline

andrew created this revision.Mon, Oct 7, 4:54 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptMon, Oct 7, 4:54 PM
andrew requested review of this revision.Mon, Oct 7, 4:54 PM
Herald added a subscriber: obrien. · View Herald TranscriptMon, Oct 7, 4:54 PM
andrew added a parent revision: D46988: dev/psci: Make SMCCC into a real driver.Mon, Oct 7, 4:54 PM
Harbormaster completed remote builds in B59817: Diff 144422.Mon, Oct 7, 4:54 PM
andrew added a reviewer: csprng.Mon, Oct 7, 4:55 PM
andrew updated this revision to Diff 144423.Mon, Oct 7, 4:56 PM

Remove an old TODO comment

Harbormaster completed remote builds in B59818: Diff 144423.Mon, Oct 7, 4:56 PM
markm accepted this revision.Mon, Oct 7, 5:15 PM
markm added a subscriber: markm.

Looks OK to me.

This revision is now accepted and ready to land.Mon, Oct 7, 5:15 PM
cem added a subscriber: cem.Mon, Oct 7, 6:10 PM
cem added inline comments.
sys/dev/psci/smccc_trng.c
113

If this source supports 192 bits per request, why truncate to 64?

118

Earlier we use arm_smccc_invoke. What’s the difference?

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
dev/
psci/
140 lines
random/
1 line
sys/
1 line

Diff 144423

View Options

sys/conf/files.arm64

Loading...
View Options

sys/dev/psci/smccc_trng.c

Loading...
View Options

sys/dev/random/random_harvestq.c

Loading...
View Options

sys/sys/random.h

Loading...