Page MenuHomeFreeBSD

sys: Add an SMCCC Random Number Generator driver
ClosedPublic

Authored by andrew on Oct 7 2024, 4:54 PM.
Tags
None
Referenced Files
F132157255: D46989.id144422.diff
Tue, Oct 14, 7:10 AM
Unknown Object (File)
Wed, Oct 8, 11:46 PM
Unknown Object (File)
Wed, Oct 8, 9:07 PM
Unknown Object (File)
Sat, Oct 4, 3:09 AM
Unknown Object (File)
Fri, Oct 3, 6:41 PM
Unknown Object (File)
Fri, Oct 3, 1:02 PM
Unknown Object (File)
Fri, Sep 26, 4:30 PM
Unknown Object (File)
Tue, Sep 16, 11:48 PM

Details

Summary

The Arm True Random Number Generator Firmware Interface provides a way
to query the SMCCC firmware for up to 192 bits of entropy. Use it to
provide another source of randomness to the kernel.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew requested review of this revision.Oct 7 2024, 4:54 PM

Remove an old TODO comment

markm added a subscriber: markm.

Looks OK to me.

This revision is now accepted and ready to land.Oct 7 2024, 5:15 PM
cem added inline comments.
sys/dev/psci/smccc_trng.c
114

If this source supports 192 bits per request, why truncate to 64?

119

Earlier we use arm_smccc_invoke. What’s the difference?

  • Check for SMCCC 1.1
  • Remove an unused variable
  • Use arm_smccc_invoke
This revision now requires review to proceed.Oct 9 2024, 9:22 AM
sys/dev/psci/smccc_trng.c
114

It's simpler to do so and we only ever ask for 64 bits in random_sources_feed

This revision is now accepted and ready to land.Oct 9 2024, 5:26 PM