The Arm True Random Number Generator Firmware Interface provides a way
to query the SMCCC firmware for up to 192 bits of entropy. Use it to
provide another source of randomness to the kernel.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59858
Build 56743: arc lint + arc unit

Event Timeline

andrew created this revision.Oct 7 2024, 4:54 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptOct 7 2024, 4:54 PM

andrew requested review of this revision.Oct 7 2024, 4:54 PM

Herald added a subscriber: obrien. · View Herald TranscriptOct 7 2024, 4:54 PM

andrew added a parent revision: D46988: dev/psci: Make SMCCC into a real driver.Oct 7 2024, 4:54 PM

Harbormaster completed remote builds in B59817: Diff 144422.Oct 7 2024, 4:54 PM

andrew added a reviewer: csprng.Oct 7 2024, 4:55 PM

Remove an old TODO comment

Harbormaster completed remote builds in B59818: Diff 144423.Oct 7 2024, 4:56 PM

Looks OK to me.

This revision is now accepted and ready to land.Oct 7 2024, 5:15 PM

cem subscribed.Oct 7 2024, 6:10 PM

cem added inline comments.

sys/dev/psci/smccc_trng.c
114	If this source supports 192 bits per request, why truncate to 64?
119	Earlier we use arm_smccc_invoke. What’s the difference?

Check for SMCCC 1.1
Remove an unused variable
Use arm_smccc_invoke

This revision now requires review to proceed.Oct 9 2024, 9:22 AM

Harbormaster completed remote builds in B59858: Diff 144518.Oct 9 2024, 9:22 AM

andrew added inline comments.Oct 9 2024, 11:37 AM

sys/dev/psci/smccc_trng.c
114	It's simpler to do so and we only ever ask for 64 bits in `random_sources_feed`

Thanks.

This revision is now accepted and ready to land.Oct 9 2024, 5:26 PM

Closed by commit rGb2f8b2dc8736: sys: Add an SMCCC Random Number Generator driver. · Explain WhyOct 15 2024, 5:30 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGb2f8b2dc8736: sys: Add an SMCCC Random Number Generator driver.

Revision Contents
Changeset List

Path

Size

sys/

conf/

files.arm64

1 line

dev/

psci/

smccc_trng.c

143 lines

random/

random_harvestq.c

1 line

sys/

random.h

1 line

Diff 144518

View Options

sys/conf/files.arm64

View Options

sys/dev/psci/smccc_trng.c

View Options

sys/dev/random/random_harvestq.c

View Options

sys: Add an SMCCC Random Number Generator driverClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 144518

sys/conf/files.arm64

sys/dev/psci/smccc_trng.c

sys/dev/random/random_harvestq.c

sys/sys/random.h

sys: Add an SMCCC Random Number Generator driver
ClosedPublic
Actions

Revision Contents
Changeset List