Differential D53181

random: remove safe(4)
Needs ReviewPublic
Actions

Authored by obrien on Sat, Oct 18, 1:36 AM.

Tags

None

Referenced Files

	F132605551: D53181.id164467.diff
	Sat, Oct 18, 8:58 AM

	F132604762: D53181.id164482.diff
	Sat, Oct 18, 8:48 AM

	F132593243: D53181.id.diff
	Sat, Oct 18, 6:22 AM

Subscribers

Details

Reviewers

None

Group Reviewers

Summary

The SafeNet SafeXcel 1141/1741 crypto accelerator only supports
deprecated & disallowed algorithms: DES, Triple-DES, AES, MD5, SHA-1,
SHA1-HMAC, and non-SP800-90B RNG.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67893
Build 64776: arc lint + arc unit

Event Timeline

obrien created this revision.Sat, Oct 18, 1:36 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptSat, Oct 18, 1:36 AM

obrien requested review of this revision.Sat, Oct 18, 1:36 AM

Harbormaster completed remote builds in B67888: Diff 164467.Sat, Oct 18, 1:36 AM

tags

Harbormaster completed remote builds in B67889: Diff 164468.Sat, Oct 18, 1:37 AM

I could only find PCI cards with this chipset (SafeXcel 140-PCI, SafeXcel 141-PCI, SafeXcel 171-PCI, and SafeXcel 241-PCI), nothing newer to plug into a modern AMD64 system. I haven't yet found any(which) SoC's may have the SafeXcel embedded, but I doubt they are 64-bit capable.

Hm, not sure I'd call AES deprecated or disallowed. But no objection to removing.

cem added inline comments.Sat, Oct 18, 3:13 AM

sys/sys/random.h
93	I think this is an ABI change, and requires the usual ABI bump machinery / caution.

PBKAC

Harbormaster completed remote builds in B67891: Diff 164470.Sat, Oct 18, 4:08 AM

add more files

Harbormaster completed remote builds in B67893: Diff 164482.Sat, Oct 18, 5:30 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

sys/

conf/

4 lines

1 line

5 lines

dev/

random/

fenestrasX/

5 lines

random_harvestq.c

1 line

safe/

modules/

2 lines

safe/

sys/

1 line

Diff 164482

share/man/man4/safe.4

Loading...

sys/conf/NOTES

Loading...

sys/conf/files

Loading...

sys/conf/options

Loading...

sys/dev/random/fenestrasX/fx_pool.c

Loading...

sys/dev/random/random_harvestq.c

Loading...

sys/dev/safe/safe.c

Loading...

sys/dev/safe/safereg.h

Loading...

sys/dev/safe/safevar.h

Loading...

sys/modules/Makefile

Loading...

sys/modules/safe/Makefile

Loading...

sys/sys/random.h

Loading...