Page MenuHomeFreeBSD
Differential D46693

random: Avoid magic numbers
ClosedPublic
Actions

Authored by cperciva on Wed, Sep 18, 5:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 22, 11:02 PM
Unknown Object (File)
Sun, Sep 22, 7:37 AM
Unknown Object (File)
Sat, Sep 21, 8:08 PM
Unknown Object (File)
Wed, Sep 18, 12:58 PM
Unknown Object (File)
Wed, Sep 18, 12:28 PM
Subscribers
cem
emaste
obrien

Details

Reviewers
imp
cem
Commits
rG32fce09268dd: random: Avoid magic numbers
Summary

Move RANDOM_FORTUNA_{NPOOLS,DEFPOOLSIZE} from fortuna.c to fortuna.h
and use RANDOM_FORTUNA_DEFPOOLSIZE in random_harvestq.c rather than
having a magic (albeit explained in a comment) number. The NPOOLS
value will be used in a later commit.

Sponsored by: Amazon

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cperciva requested review of this revision.Wed, Sep 18, 5:14 AM
cperciva created this revision.
Herald added a subscriber: obrien. · View Herald TranscriptWed, Sep 18, 5:14 AM
Harbormaster completed remote builds in B59517: Diff 143410.Wed, Sep 18, 5:14 AM
cperciva mentioned this in D46635: loader: Expand EFI entropy if < 2048 bytes.Wed, Sep 18, 7:12 AM
emaste added a subscriber: emaste.Wed, Sep 18, 3:17 PM
cem accepted this revision.Wed, Sep 18, 3:34 PM
cem added a subscriber: cem.

LGTM.

This revision is now accepted and ready to land.Wed, Sep 18, 3:34 PM
cem added inline comments.Wed, Sep 18, 3:39 PM
sys/dev/random/fortuna.c
86–89

Note (for the other change) that pool size is hypothetically tunable.

Closed by commit rG32fce09268dd: random: Avoid magic numbers (authored by cperciva). · Explain WhySun, Sep 22, 7:36 AM
This revision was automatically updated to reflect the committed changes.
cperciva added a commit: rG32fce09268dd: random: Avoid magic numbers.

Revision Contents
Changeset List

PathSize
sys/
dev/
random/
4 lines
2 lines
9 lines

Diff 143592

View Options

sys/dev/random/fortuna.h

Loading...
View Options

sys/dev/random/fortuna.c

Loading...
View Options

sys/dev/random/random_harvestq.c

Loading...