LGTM

@des Please commit this and MFC to stable/15 ASAP so I can get it into 15.0-RC4 builds on Monday.

In D53800#1228896, @adamw wrote:

@cperciva If you add vim and emacs, I'd happily give an approval from the ports side of things. (I'm no longer on portmgr, so not sure how much my +1 is worth to you.)

In D53800#1228929, @vvd wrote:

What compression do you use?
pkg create firefox => 73056762
pkg create -f txz -T 1 -l 9 firefox => 66061788
It's ~9.6% diff.

Ok, there seems to be consensus here that this is the right thing to do, so you want to commit this and MFC tomorrow, I'll take it for 15.0-RC3.

In D53800#1228878, @mark_freebsdfoundation.org wrote:

In D53800#1228847, @cperciva wrote:

But the the choice is actually "remove GNOME *and freebsd-doc* in order to keep KDE".

*nod* I get you @cperciva

Apologies for asking what might be a daft question then — but removing www/firefox, x11/gnome and x11-wm/sway doesn't make KDE fit, does it? (the question might be daft as I'm guessing you've tried umpteen permutations to make this work).

In D53800#1228648, @mark_freebsdfoundation.org wrote:

Colin, although I wouldn't pick KDE myself, I can't help but think since it's the desktop of choice in the upcoming addition to the installer (Alfonso's work) wouldn't it be more prudent to remove *all other* DEs/WMs from the DVD image (since they're all smaller anyway) and have just KDE on the DVD image? "You can't keep all the people happy all the time", but if we've settled on one DE [for starters] for the installer add on, I can't help thinking it would be useful for that desktop to be in the DVD image :)

Fix indentation

In D53795#1228520, @markj wrote:

We should really just do this in a central place in vmimage.subr, but that can be a separate change.