Page MenuHomeFreeBSD
Differential D53796

GCE: Add /usr/src and /usr/ports to METALOG
ClosedPublic
Actions

Authored by cperciva on Tue, Nov 18, 1:09 AM.
Tags
None
Referenced Files
F136682152: D53796.id.diff
Tue, Nov 18, 9:21 PM
F136653691: D53796.id166638.diff
Tue, Nov 18, 6:30 PM
F136636529: D53796.diff
Tue, Nov 18, 4:42 PM
F136625175: D53796.id166636.diff
Tue, Nov 18, 3:30 PM
F136624971: D53796.id166640.diff
Tue, Nov 18, 3:28 PM
F136616798: D53796.id166636.diff
Tue, Nov 18, 2:41 PM
F136610201: D53796.id166640.diff
Tue, Nov 18, 2:01 PM
F136609975: D53796.id166638.diff
Tue, Nov 18, 1:59 PM
View All 15 Files
Subscribers
imp
ivy
jrtc27
markj

Details

Reviewers
markj
Commits
rG0f4c3dcd1e07: GCE: Add /usr/src and /usr/ports to METALOG
rG10ef3bf823c5: GCE: Add /usr/src and /usr/ports to METALOG
rG0dbb00733c4a: GCE: Add /usr/src and /usr/ports to METALOG
Summary

We ship these in order to comply with GCE Marketplace rules about
providing source code and licenses for all the software we ship as
part of images.

MFC after: immediately (15.0-RC2)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cperciva created this revision.Tue, Nov 18, 1:09 AM
Herald added subscribers: ivy, jrtc27, imp. · View Herald TranscriptTue, Nov 18, 1:09 AM
cperciva requested review of this revision.Tue, Nov 18, 1:09 AM
Harbormaster completed remote builds in B68705: Diff 166636.Tue, Nov 18, 1:09 AM
cperciva added a parent revision: D53795: release: Add /boot/loader.conf to some cloudware.Tue, Nov 18, 1:09 AM
cperciva added a child revision: D53797: release: Add a MISSING_METALOGS hack to VMs.
markj accepted this revision.Tue, Nov 18, 1:48 AM
markj added a subscriber: markj.

This won't preserve symlinks. That probably won't hurt too much.

Rather than looping like this, I think you can instead run something like mtree -c -p ./usr/src | mtree -C -k uname,gname,type,mode >> ${DESTDIR}/METALOG. I think you'd still need a way to override the uname/gname for non-root builds, though, and I don't see an existing mechanism in mtree(8) to do that, so ok.

release/tools/gce.conf
104

Indentation here is wonky.

118

Same here.

This revision is now accepted and ready to land.Tue, Nov 18, 1:48 AM
cperciva updated this revision to Diff 166638.Tue, Nov 18, 1:50 AM

Fix indentation

This revision now requires review to proceed.Tue, Nov 18, 1:50 AM
Harbormaster completed remote builds in B68707: Diff 166638.Tue, Nov 18, 1:50 AM
cperciva added inline comments.Tue, Nov 18, 1:50 AM
release/tools/gce.conf
104

Better now?

markj added inline comments.Tue, Nov 18, 1:51 AM
release/tools/gce.conf
104

Looks ok now, yes.

markj accepted this revision.Tue, Nov 18, 2:01 AM
This revision is now accepted and ready to land.Tue, Nov 18, 2:01 AM
Closed by commit rG0dbb00733c4a: GCE: Add /usr/src and /usr/ports to METALOG (authored by cperciva). · Explain WhyTue, Nov 18, 2:19 AM
This revision was automatically updated to reflect the committed changes.
cperciva added a commit: rG0dbb00733c4a: GCE: Add /usr/src and /usr/ports to METALOG.
cperciva added a commit: rG10ef3bf823c5: GCE: Add /usr/src and /usr/ports to METALOG.
cperciva added a commit: rG0f4c3dcd1e07: GCE: Add /usr/src and /usr/ports to METALOG.Tue, Nov 18, 2:22 AM

Revision Contents
Changeset List

PathSize
release/
tools/
8 lines

Diff 166640

View Options

release/tools/gce.conf

Loading...