Page MenuHomeFreeBSD

pam_krb5: Fix manual page in MIT case
ClosedPublic

Authored by des on Sat, Nov 22, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 13, 3:07 AM
Unknown Object (File)
Thu, Dec 4, 8:03 AM
Unknown Object (File)
Wed, Dec 3, 8:35 AM
Unknown Object (File)
Sun, Nov 30, 10:23 PM
Unknown Object (File)
Sat, Nov 29, 7:30 PM
Unknown Object (File)
Fri, Nov 28, 7:19 PM
Unknown Object (File)
Fri, Nov 28, 6:33 PM
Unknown Object (File)
Thu, Nov 27, 11:41 PM
Subscribers

Details

Summary
  • Always install the manual page as pam_krb5(8) regardless of which version we're using.
  • Regenerate it using pod2mdoc instead of pod2man so it doesn't claim to be part of “User Contributed Perl Documentation”.
  • Put the correct section number in the header and footer.
  • Don't cross-reference non-existent pam(7) manual page.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy added inline comments.
lib/libpam/modules/pam_krb5/Makefile
79

i don't quite follow this. when would this not exist?

cperciva added inline comments.
lib/libpam/modules/pam_krb5/Makefile
79

As part of release building, for one thing. It's part of the textproc/pod2mdoc port.

I don't think we should be building the base system differently based on which ports people have installed...

lib/libpam/modules/pam_krb5/Makefile
79

if this is from a port, it should be part of the vendor import process, not something run from a Makefile.

lib/libpam/modules/pam_krb5/Makefile
79

+1

lib/libpam/modules/pam_krb5/Makefile
79

This is mostly just to document how the manual page was generated (and should be regenerated on update). The exists test can never be true since it only searches .PATH, not ${PATH}. I can replace it with .if !exists(pam-krb5.8) if you like, that way it's only rebuilt if you manually delete it.

lib/libpam/modules/pam_krb5/Makefile
79

I would prefer .ifdef(I_AM_DOING_A_VENDOR_IMPORT) or something like that to make the purpose clear. This already confused three of us. :-)

des marked 5 inline comments as done.Mon, Nov 24, 1:02 AM
This revision is now accepted and ready to land.Mon, Nov 24, 1:13 AM
This revision was automatically updated to reflect the committed changes.