Page MenuHomeFreeBSD

ena: exponential backoff exp limit
Needs ReviewPublic

Authored by osamaabb_amazon.com on Aug 20 2024, 8:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 9:42 PM
Unknown Object (File)
Sat, Jan 18, 1:05 AM
Unknown Object (File)
Dec 8 2024, 8:06 PM
Unknown Object (File)
Nov 25 2024, 10:23 AM
Unknown Object (File)
Nov 19 2024, 10:53 PM
Unknown Object (File)
Nov 19 2024, 2:03 PM
Unknown Object (File)
Nov 19 2024, 10:41 AM
Unknown Object (File)
Nov 19 2024, 7:42 AM
Subscribers

Details

Reviewers
cperciva
Summary

This patch limits the exponent in the exponential backoff
mechanism in order to avoid the value overflowing.

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 59059
Build 55946: arc lint + arc unit

Event Timeline

Dumb question, but where does the delay_us value which is passed to this come from? It looks like it come from ena_min_poll_delay_us which... as far as I can tell is never set? Is this just vestigal code or am I missing something?

Dumb question, but where does the delay_us value which is passed to this come from? It looks like it come from ena_min_poll_delay_us which... as far as I can tell is never set? Is this just vestigal code or am I missing something?

You're correct, added such a patch in [1]
[1] https://reviews.freebsd.org/D46763