Page MenuHomeFreeBSD

ena: exponential backoff exp limit
Needs ReviewPublic

Authored by osamaabb_amazon.com on Aug 20 2024, 8:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 8, 6:04 PM
Unknown Object (File)
Fri, Sep 4, 9:37 PM
Unknown Object (File)
Fri, Sep 4, 9:29 PM
Unknown Object (File)
Tue, Sep 1, 8:52 AM
Unknown Object (File)
Mon, Aug 31, 8:23 PM
Unknown Object (File)
Sat, Aug 29, 9:15 AM
Unknown Object (File)
Wed, Aug 26, 5:46 AM
Unknown Object (File)
Mon, Aug 17, 9:35 PM
Subscribers

Details

Reviewers
cperciva
Summary

This patch limits the exponent in the exponential backoff
mechanism in order to avoid the value overflowing.

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 59059
Build 55946: arc lint + arc unit

Event Timeline

Dumb question, but where does the delay_us value which is passed to this come from? It looks like it come from ena_min_poll_delay_us which... as far as I can tell is never set? Is this just vestigal code or am I missing something?

Dumb question, but where does the delay_us value which is passed to this come from? It looks like it come from ena_min_poll_delay_us which... as far as I can tell is never set? Is this just vestigal code or am I missing something?

You're correct, added such a patch in [1]
[1] https://reviews.freebsd.org/D46763