ena: Trigger reset when mbuf is NULL error happens
Needs ReviewPublic
Actions

Authored by osamaabb_amazon.com on Aug 20 2024, 8:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 12, 5:26 PM

	Unknown Object (File)
	Mon, Aug 10, 5:38 PM

	Unknown Object (File)
	Mon, Aug 10, 8:59 AM

	Unknown Object (File)
	Mon, Aug 10, 7:00 AM

	Unknown Object (File)
	Sun, Aug 9, 6:34 PM

	Unknown Object (File)
	Sat, Aug 8, 2:34 AM

	Unknown Object (File)
	Wed, Aug 5, 4:57 AM

	Unknown Object (File)
	Tue, Aug 4, 9:04 AM

View All 70 Files

Subscribers

imp

Details

Reviewers

cperciva

Summary

The mbuf is NULL issue happens when the device sends the driver
a completion with a wrong request id.
Trigger a reset whenever this happens.

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 59092
Build 55979: arc lint + arc unit

Event Timeline

osamaabb_amazon.com created this revision.Aug 20 2024, 8:47 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 20 2024, 8:47 AM

osamaabb_amazon.com requested review of this revision.Aug 20 2024, 8:47 AM

Harbormaster completed remote builds in B59092: Diff 142222.Aug 20 2024, 8:47 AM

This seems like it could be a kernel panic rather than merely logging an error and resetting the device.

In D46363#1064460, @cperciva wrote:

This seems like it could be a kernel panic rather than merely logging an error and resetting the device.

We're using the same approach as in [1] here, in case theres a single bit flip causing a funny RX request ID being processed by the driver (hence the null mbuf) we'd like to maintain networking availability
[1] https://reviews.freebsd.org/D46337

Revision Contents
Changeset List

Path

Size

sys/

dev/

ena/

ena_datapath.c

8 lines

Diff 142222

View Options

sys/dev/ena/ena_datapath.c

ena: Trigger reset when mbuf is NULL error happensNeeds ReviewPublicActions