Differential D46332

ena: Add pci bus parameter to ENA_MEMCPY_TO_DEVICE_64
Needs ReviewPublic
Actions

Authored by osamaabb_amazon.com on Aug 20 2024, 8:45 AM.

Details

Reviewers

cperciva

Summary

ENA_MEMCPY_TO_DEVICE_64 macro needs pci bus id in order
to write to the device memory when using llq.

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 59061
Build 55948: arc lint + arc unit

Event Timeline

osamaabb_amazon.com created this revision.Aug 20 2024, 8:45 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 20 2024, 8:45 AM

osamaabb_amazon.com requested review of this revision.Aug 20 2024, 8:45 AM

Harbormaster completed remote builds in B59061: Diff 142191.Aug 20 2024, 8:45 AM

ENA_MEMCPY_TO_DEVICE_64 macro needs pci bus id

... but it's not using it?

BTW "parmater" -> "parameter" in the title.

osamaabb_amazon.com retitled this revision from ena: Add pci bus parmater to ENA_MEMCPY_TO_DEVICE_64 to ena: Add pci bus parameter to ENA_MEMCPY_TO_DEVICE_64.Sep 23 2024, 8:12 AM

In D46332#1064443, @cperciva wrote:

BTW "parmater" -> "parameter" in the title.

Fixed

In D46332#1064442, @cperciva wrote:

ENA_MEMCPY_TO_DEVICE_64 macro needs pci bus id

... but it's not using it?

You're right, as ena-com is shared between multiple driver - this code is used by other drivers

In D46332#1064442, @cperciva wrote:

ENA_MEMCPY_TO_DEVICE_64 macro needs pci bus id

... but it's not using it?

You're correct, at the moment, this parameter isn't used by the FreeBSD driver. The ena-com layer is shared across multiple drivers, but this specific parameter isn't utilized in the fbsd driver for now