Page MenuHomeFreeBSD

ena: Rename fields to MBZ in completion descriptors
Needs ReviewPublic

Authored by osamaabb_amazon.com on Aug 20 2024, 8:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 11 2025, 4:19 PM
Unknown Object (File)
Jul 28 2025, 3:29 PM
Unknown Object (File)
Jul 5 2025, 5:10 AM
Unknown Object (File)
Jul 4 2025, 2:20 PM
Unknown Object (File)
Jun 27 2025, 11:57 AM
Unknown Object (File)
Jun 23 2025, 7:42 AM
Unknown Object (File)
Jun 14 2025, 7:21 PM
Unknown Object (File)
Apr 21 2025, 1:27 AM
Subscribers

Details

Reviewers
cperciva
Summary

Several reserved bits in ena_eth_io_tx_cdesc and
ena_eth_io_rx_cdesc_base have been renamed explicitly to
MBZ (Must Be Zero).
These bits are set by the device to zero before being sent
to the driver. The fields are used as an integrity check in
order to ensure that the received descriptor is not corrupted.

in ena_eth_io_tx_cdesc, two reserved bits from the flags
field are marked as MBZ.

in ena_eth_io_rx_cdesc_base, there are 8 reserved bits
(7 and 17-23). Out of the above, bits 7 and 17 are MBZ.

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 59063
Build 55950: arc lint + arc unit

Event Timeline

It seems a bit weird to define functions for setting bits which Must Be Zero, but this looks rather like generated code so I guess that's why?

It seems a bit weird to define functions for setting bits which Must Be Zero, but this looks rather like generated code so I guess that's why?

You're correct, I hope that okay

It seems a bit weird to define functions for setting bits which Must Be Zero, but this looks rather like generated code so I guess that's why?

You're correct, I hope that okay

Yep totally fine, just wanted to make sure it was intentional. :-)