Page MenuHomeFreeBSD

route.8: Describe metric modifier
Needs ReviewPublic

Authored by pouria on Fri, May 15, 10:03 PM.
Tags
None
Referenced Files
F157160298: D57025.diff
Mon, May 18, 9:39 PM
F157051162: D57025.diff
Mon, May 18, 3:49 AM
Unknown Object (File)
Sun, May 17, 6:52 AM
Unknown Object (File)
Sat, May 16, 1:35 PM
Subscribers

Details

Reviewers
glebius
ziaee
Group Reviewers
network
manpages
Summary

Describe -metric argument in the route manual.

Depends on D56335

Test Plan

mandoc lint:
mandoc -Tlint sbin/route/route.8

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73137
Build 70020: arc lint + arc unit

Event Timeline

Thanks for doing this!

sbin/route/route.8
178

I don't have experience doing advanced networking, but should there also be some kind of structure in this area somewhere so it says something like:

route [-n] command [-net | -host] destination [gateway [-weight] [netmask]] [-fib number]

329

Maybe?

sbin/route/route.8
178

I don't have experience doing advanced networking, but should there also be some kind of structure in this area somewhere so it says something like:

route [-n] command [-net | -host] destination [gateway [-weight] [netmask]] [-fib number]

You're right, we should include -weight and -metric in that too.
but there are too many keywords too include AND you can use -metric without specifying -gateway during route del and vice versa.
So [gateway [-weight] [netmask]] won't help much.

329

I prefer to use word selected instead of preferred.
words like cost, metric, preference are similar but have their own technical meaning in routing stack.
I don't want to accidentally confuse users.

sbin/route/route.8
178

sounds like we need another list like what's on 335. we could do that in a followup commit, if you want?

329

okay, thanks for explaining!

sbin/route/route.8
178

Yes! That's a good idea.
I'll work on one in another revision.