Page MenuHomeFreeBSD
Differential D56188

netlink: Fix RTA_MULTIPATH on RTM_GETROUTE
ClosedPublic
Actions

Authored by pouria on Mar 31 2026, 4:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 25, 10:28 PM
Unknown Object (File)
Thu, Jun 25, 2:35 AM
Unknown Object (File)
Thu, Jun 25, 12:09 AM
Unknown Object (File)
Wed, Jun 24, 9:31 AM
Unknown Object (File)
Wed, Jun 24, 8:41 AM
Unknown Object (File)
Wed, Jun 24, 5:26 AM
Unknown Object (File)
Tue, Jun 23, 11:45 AM
Unknown Object (File)
Wed, Jun 17, 4:35 AM
View All 39 Files
Subscribers
imp
melifaro

Details

Reviewers
kp
markj
glebius
zlei
melifaro
Group Reviewers
network
Commits
rG84bb3648d215: netlink: Fix RTA_MULTIPATH on RTM_GETROUTE
Summary

Before this patch, netlink never returned RTA_MULTIPATH.
Also, add RTA_MULTIPATH attribute in way that don't confuse
non-mpath support consumers.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pouria created this revision.Mar 31 2026, 4:08 PM
Herald added a reviewer: melifaro. · View Herald TranscriptMar 31 2026, 4:08 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
pouria requested review of this revision.Mar 31 2026, 4:08 PM
pouria added a parent revision: D56187: routing: Implement merge of nhgrp in new multipath route.
pouria added a child revision: D56189: routing: Expire nhops inside the nhgrp.
Harbormaster completed remote builds in B71866: Diff 174672.Mar 31 2026, 4:09 PM
pouria added inline comments.Mar 31 2026, 4:31 PM
sys/netlink/route/rt.c
189

For reviewers, Without this, non-mpath aware apps can't find their gw, therefore, we choose one here for netlink users. see line 658 below.

349–353

For reviewers, without these changes here + removal of nhop_select_func() from line 658 it was impossible to return RTA_MULTIPATH.
Since we overwrite nhgrp of rnd by nhop_select_func() to nhop. So this patch will restore the intended behavior.

pouria added a comment.Mar 31 2026, 5:11 PM
This comment was removed by pouria.
pouria updated this revision to Diff 175145.Apr 8 2026, 7:20 PM

Also return the weight of selected nhop from nhgrp.

Harbormaster completed remote builds in B72065: Diff 175145.Apr 8 2026, 7:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 30 2026, 10:08 PM
Closed by commit rG84bb3648d215: netlink: Fix RTA_MULTIPATH on RTM_GETROUTE (authored by pouria). · Explain Why
This revision was automatically updated to reflect the committed changes.
pouria added a commit: rG84bb3648d215: netlink: Fix RTA_MULTIPATH on RTM_GETROUTE.

Revision Contents
Changeset List

PathSize
sys/
netlink/
route/
42 lines

Diff 176961

View Options

sys/netlink/route/rt.c

Loading...