Paths

Table of Contentst

Differential D56188

netlink: Fix RTA_MULTIPATH on RTM_GETROUTE
ClosedPublic
Actions

Authored by pouria on Mar 31 2026, 4:08 PM.

Tags

None

Referenced Files

	F171189270: D56188.id.diff
	Wed, Sep 9, 9:19 AM

	F171146340: D56188.id174672.diff
	Wed, Sep 9, 12:18 AM

	Unknown Object (File)
	Tue, Sep 8, 5:07 AM

	Unknown Object (File)
	Mon, Sep 7, 9:24 AM

	Unknown Object (File)
	Sun, Sep 6, 12:02 PM

	Unknown Object (File)
	Fri, Sep 4, 1:54 PM

	Unknown Object (File)
	Fri, Sep 4, 12:28 AM

	Unknown Object (File)
	Wed, Aug 19, 6:01 AM

View All 75 Files

Subscribers

Details

Reviewers

kp
markj
glebius
zlei
melifaro

Group Reviewers

Commits

rG84bb3648d215: netlink: Fix RTA_MULTIPATH on RTM_GETROUTE

Summary

Before this patch, netlink never returned RTA_MULTIPATH.
Also, add RTA_MULTIPATH attribute in way that don't confuse
non-mpath support consumers.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pouria created this revision.Mar 31 2026, 4:08 PM

Herald added a reviewer: melifaro. · View Herald TranscriptMar 31 2026, 4:08 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

pouria requested review of this revision.Mar 31 2026, 4:08 PM

pouria added a parent revision: D56187: routing: Implement merge of nhgrp in new multipath route.

pouria added a child revision: D56189: routing: Expire nhops inside the nhgrp.

Harbormaster completed remote builds in B71866: Diff 174672.Mar 31 2026, 4:09 PM

pouria added inline comments.Mar 31 2026, 4:31 PM

sys/netlink/route/rt.c
189	For reviewers, Without this, non-mpath aware apps can't find their gw, therefore, we choose one here for netlink users. see line 658 below.
349–353	For reviewers, without these changes here + removal of `nhop_select_func()` from line 658 it was impossible to return `RTA_MULTIPATH`. Since we overwrite `nhgrp` of `rnd` by `nhop_select_func()` to `nhop`. So this patch will restore the intended behavior.

pouria added a comment.Mar 31 2026, 5:11 PM

This comment was removed by pouria.

Also return the weight of selected nhop from nhgrp.

Harbormaster completed remote builds in B72065: Diff 175145.Apr 8 2026, 7:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 30 2026, 10:08 PM

Closed by commit rG84bb3648d215: netlink: Fix RTA_MULTIPATH on RTM_GETROUTE (authored by pouria). · Explain Why

This revision was automatically updated to reflect the committed changes.

pouria added a commit: rG84bb3648d215: netlink: Fix RTA_MULTIPATH on RTM_GETROUTE.

Revision Contents
Changeset List

Path

Size

sys/

netlink/

route/

42 lines

Diff 176961

sys/netlink/route/rt.c

Loading...