Page MenuHomeFreeBSD

libcrypto: compile all PIC objects with -DOPENSSL_PIC
Needs ReviewPublic

Authored by ngie on Sun, Apr 21, 5:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 2:48 PM
Unknown Object (File)
Fri, Apr 26, 3:54 PM
Unknown Object (File)
Fri, Apr 26, 3:54 PM
Unknown Object (File)
Fri, Apr 26, 3:54 PM
Unknown Object (File)
Fri, Apr 26, 10:34 AM
Unknown Object (File)
Wed, Apr 24, 5:41 PM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This change modifies the libcrypto PIC objects to always link with
-DOPENSSL_PIC to restore parity with the upstream build process. This
ensures that -DOPENSSL_PIC is used whenever building the auxiliary
shared objects, e.g., the fips provider, the legacy provider, etc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 57262
Build 54150: arc lint + arc unit

Event Timeline

ngie requested review of this revision.Sun, Apr 21, 5:45 PM

Fix the change to properly append the CFLAG to PICFLAG and do it after including bsd.lib.mk to properly compile/link libcrypto.so.