Paths

Table of Contentst

Differential D44896

libcrypto: compile all PIC objects with -DOPENSSL_PIC
ClosedPublic
Actions

Authored by ngie on Apr 21 2024, 5:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 15, 10:09 AM

	Unknown Object (File)
	Wed, Apr 15, 12:28 AM

	Unknown Object (File)
	Tue, Apr 14, 3:59 AM

	Unknown Object (File)
	Sat, Apr 11, 6:32 PM

	Unknown Object (File)
	Sat, Apr 11, 2:34 PM

	Unknown Object (File)
	Sat, Apr 11, 6:36 AM

	Unknown Object (File)
	Thu, Apr 9, 11:37 PM

	Unknown Object (File)
	Mon, Apr 6, 3:38 PM

View All 95 Files

Subscribers

Details

Reviewers

Commits

rG3797fe720a37: libcrypto: compile all PIC objects with -DOPENSSL_PIC -fPIC
rG14b9955e57cc: libcrypto: compile all PIC objects with -DOPENSSL_PIC

Summary

This change modifies the libcrypto PIC objects to always link with
-DOPENSSL_PIC to restore parity with the upstream build process. This
ensures that -DOPENSSL_PIC is used whenever building the auxiliary
shared objects, e.g., the fips provider, the legacy provider, etc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Apr 21 2024, 5:45 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 21 2024, 5:45 PM

ngie requested review of this revision.Apr 21 2024, 5:45 PM

Harbormaster completed remote builds in B57260: Diff 137465.Apr 21 2024, 5:45 PM

Fix the change to properly append the CFLAG to PICFLAG and do it after including bsd.lib.mk to properly compile/link libcrypto.so.

Harbormaster completed remote builds in B57262: Diff 137467.Apr 21 2024, 6:37 PM

e.g., the fips provider, the legacy provider, etc.

Actually it is precisely just those two

Move the definition to secure/lib/libcrypto/modules/Makefile.inc

This only affects modules - nothing else.

Harbormaster completed remote builds in B71560: Diff 173963.Thu, Mar 19, 11:59 PM

emaste accepted this revision.Fri, Mar 20, 12:44 AM

This revision is now accepted and ready to land.Fri, Mar 20, 12:44 AM

Closed by commit rG14b9955e57cc: libcrypto: compile all PIC objects with -DOPENSSL_PIC (authored by ngie). · Explain WhyFri, Mar 20, 12:52 AM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG14b9955e57cc: libcrypto: compile all PIC objects with -DOPENSSL_PIC.

ngie added a reverting change: rG67b918e03475: Revert "libcrypto: compile all PIC objects with -DOPENSSL_PIC".Fri, Mar 20, 8:12 PM

ngie added a commit: rG3797fe720a37: libcrypto: compile all PIC objects with -DOPENSSL_PIC -fPIC.Sun, Mar 22, 1:39 AM

Revision Contents
Changeset List

Path

Size

secure/

lib/

libcrypto/

modules/

2 lines

Diff 173966

secure/lib/libcrypto/modules/Makefile.inc

Loading...