Page MenuHomeFreeBSD
Differential D44894

libcrypto, libssl: link .so's with -Bsymbolic for upstream parity
Needs ReviewPublic
Actions

Authored by ngie on Apr 21 2024, 5:44 PM.
Tags
None
Referenced Files
F176086548: D44894.id137468.diff
Thu, Oct 15, 11:58 PM
F176086389: D44894.id137463.diff
Thu, Oct 15, 11:56 PM
Unknown Object (File)
Thu, Oct 1, 11:14 AM
Unknown Object (File)
Sat, Sep 19, 1:25 AM
Unknown Object (File)
Sep 15 2026, 8:52 PM
Unknown Object (File)
Sep 11 2026, 7:11 PM
Unknown Object (File)
Sep 4 2026, 5:40 PM
Unknown Object (File)
Aug 21 2026, 11:13 AM
View All 87 Files
Subscribers
imp

Details

Reviewers
cy
emaste
Summary

This change modifies libcrypto, libssl, and dependent .so files to use
-Wl,-Bsymbolic to prefer locally defined symbols over globally defined
symbols in order to have parity with the upstream OpenSSL build process.

Test Plan

TODO: run tinderbox build

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57263
Build 54151: arc lint + arc unit

Event Timeline

ngie created this revision.Apr 21 2024, 5:44 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 21 2024, 5:44 PM
ngie requested review of this revision.Apr 21 2024, 5:44 PM
Harbormaster completed remote builds in B57258: Diff 137463.Apr 21 2024, 5:44 PM
ngie edited the test plan for this revision. (Show Details)Apr 21 2024, 6:35 PM
ngie added reviewers: cy, emaste.
ngie updated this revision to Diff 137468.Apr 21 2024, 6:39 PM

-Wl,-Bsymbolic should be added to SOLINKOPTS instead of LDFLAGS

This avoids breaking the static object build case.

Harbormaster completed remote builds in B57263: Diff 137468.Apr 21 2024, 6:39 PM

Revision Contents
Changeset List

PathSize
secure/
lib/
libcrypto/
2 lines
modules/
fips/
2 lines
legacy/
2 lines
libssl/
2 lines

Diff 137468

View Options

secure/lib/libcrypto/Makefile.common

Loading...
View Options

secure/lib/libcrypto/modules/fips/Makefile

Loading...
View Options

secure/lib/libcrypto/modules/legacy/Makefile

Loading...
View Options

secure/lib/libssl/Makefile

Loading...