Page MenuHomeFreeBSD

radlib: fix a memory leak
ClosedPublic

Authored by ngie on Jun 4 2024, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 5:23 PM
Unknown Object (File)
Fri, Oct 10, 3:37 PM
Unknown Object (File)
Sat, Oct 4, 1:34 AM
Unknown Object (File)
Fri, Oct 3, 8:34 PM
Unknown Object (File)
Fri, Oct 3, 2:54 AM
Unknown Object (File)
Thu, Oct 2, 8:42 AM
Unknown Object (File)
Wed, Oct 1, 3:06 PM
Unknown Object (File)
Wed, Oct 1, 1:25 PM
Subscribers

Details

Summary

Call HMAC_CTX_free if returning early from is_valid_request when
processing Message-Authenticator tags.

Reported by: Coverity

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie requested review of this revision.Jun 4 2024, 8:03 PM
ngie added a reviewer: emaste.
erj added a subscriber: erj.

It looks like it matches the cleanup that happens in the other return paths to me

This revision is now accepted and ready to land.Jun 4 2024, 8:07 PM
markj added a subscriber: markj.

Please add Fixes: 8d5c7813061d ("libradius: Fix input validation bugs") to the commit log message.

Please add Fixes: 8d5c7813061d ("libradius: Fix input validation bugs") to the commit log message.

Done!

This revision was automatically updated to reflect the committed changes.