radlib: fix a memory leak
ClosedPublic
Actions

Authored by ngie on Jun 4 2024, 8:03 PM.

Details

Reviewers

emaste
erj
markj
allanjude

Commits

rGc2dca1b5607f: radlib: fix a memory leak in `is_valid_request`
rG77c04f3eb12a: radlib: fix a memory leak in `is_valid_request`

Summary

Call HMAC_CTX_free if returning early from is_valid_request when
processing Message-Authenticator tags.

Reported by: Coverity

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58057
Build 54945: arc lint + arc unit

Event Timeline

ngie created this revision.Jun 4 2024, 8:03 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 4 2024, 8:03 PM

ngie requested review of this revision.Jun 4 2024, 8:03 PM

Harbormaster completed remote builds in B58057: Diff 139467.Jun 4 2024, 8:03 PM

ngie edited the summary of this revision. (Show Details)Jun 4 2024, 8:04 PM

ngie added a reviewer: emaste.

It looks like it matches the cleanup that happens in the other return paths to me

This revision is now accepted and ready to land.Jun 4 2024, 8:07 PM

Please add Fixes: 8d5c7813061d ("libradius: Fix input validation bugs") to the commit log message.

allanjude accepted this revision.Jun 4 2024, 8:12 PM

emaste accepted this revision.Jun 4 2024, 8:14 PM

In D45488#1037640, @markj wrote:

Please add Fixes: 8d5c7813061d ("libradius: Fix input validation bugs") to the commit log message.

Done!

Closed by commit rG77c04f3eb12a: radlib: fix a memory leak in `is_valid_request` (authored by ngie). · Explain WhyJun 5 2024, 2:42 AM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG77c04f3eb12a: radlib: fix a memory leak in `is_valid_request`.

ngie added a commit: rGc2dca1b5607f: radlib: fix a memory leak in `is_valid_request`.Sep 28 2024, 3:55 AM

Revision Contents
Changeset List

Path

Size

lib/

libradius/

radlib.c

4 lines

Diff 139467

View Options

radlib: fix a memory leakClosedPublicActions