net-mgmt/lldpd: Update to 1.0.18

[john_saltant.com]

Summary

• Update to 1.0.18
• Take maintainership
• Use writable chroot for timezone file
• USES=pkgconfig to detect system libevent
• Remove obsolete (since 0.9.7) JSON option
• Remove unnecessary USES=libedit with XML option
• Pet portlint and other minor improvements

Changelogs:

• https://github.com/lldpd/lldpd/releases/tag/1.0.15
• https://github.com/lldpd/lldpd/releases/tag/1.0.16
• https://github.com/lldpd/lldpd/releases/tag/1.0.17
• https://github.com/lldpd/lldpd/releases/tag/1.0.18

Sponsored by: Saltant Solutions LLC

Test Plan

• Build with all options (except DTRACE) enabled
• Install package, enable and run service
• Run lldpcli show nei

[ngie]

LGTM -- thank you!

[diizzy]

Hi,

Your patch with a few additional changes,
https://projects.pyret.net/files/freebsd-patches/lldpd-fixup.patch

PORTVERSION --> DISTVERSION
Add GitHub as primary source and media.luffy.cx as fallback (change to HTTPS while at it)
Rearrage some variables for better readability and closer follow other ports in tree
Use c99 instead of gnu99
Unbundle libevent
Remove DTRACE option, if it's broken there no need to keep it in at all
Remove git noise
"Fix" overlinking when SNMP option is enabled (this should be fixed in net-snmp's port though)

Poudriere testport OK on 13.3 and 14.1 (amd64)

Best regards.
Daniel

[john_saltant.com]

Daniel,

Thank you for your interest and your feedback. It would be helpful if you could post each of your proposed changes to this revision independently, against a specific part of the diff, where possible. I expect I will accept most, maybe all, of your suggestions. Seeing them separated as you intend would make it much easier to comprehend and assess them.

Also, I would appreciate it if you were to assign PR277851 to yourself. I will feel better about undertaking the work of analyzing and testing a new, non-trivial patch if I have some confidence that the fruits of my labor will end up landing in the ports tree in a timely manner.

Regards,
John