t_strcpy.c: extend and enhance
AbandonedPublic
Actions

Authored by fuz on Aug 21 2023, 8:22 AM.

Details

Reviewers

Summary

Add some additional test cases to NetBSD's strcpy tests.
These were required to catch some bugs in the new stpcpy routine
presented in D41349.

Also extend the tests to permit loading an external strcpy function
and testing it over using the libc version. This was added by the
example of other tests in the test suite doing the same thing and
helped tremendously in development.

These bits were originally part of D41349 but were taken out by
@ngie's request.

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 53197
Build 50088: arc lint + arc unit

Event Timeline

fuz created this revision.Aug 21 2023, 8:22 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 21 2023, 8:22 AM

fuz requested review of this revision.Aug 21 2023, 8:22 AM

Harbormaster completed remote builds in B53197: Diff 126288.Aug 21 2023, 8:22 AM

mjg mentioned this in D41442: lib/libc/amd64/string: add baseline implementation of memcmp, bcmp.Aug 21 2023, 8:28 AM

Any progress with this one?

fuz mentioned this in D41970: lib/libc/tests/string: add extended unit tests for strcmp().Sep 27 2023, 3:03 AM

Should this still be open, given that you have done a functionally equivalent change in D41970?

In D41520#963073, @ngie wrote:

Should this still be open, given that you have done a functionally equivalent change in D41970?

The change in D41520 is about the strcmp tests, this one is about the strcpy tests. Different files, but basically the same change. I need specific approval to commit any changes as I do not have a commit bit for src.

fuz mentioned this in D42216: contrib/netbsd-tests/lib/libc/string/t_strrchr.c: allow use of a custom strrchr function.Oct 16 2023, 12:44 AM

fuz mentioned this in D42217: lib/libc/amd64/string: add strrchr scalar, baseline implementation.Oct 16 2023, 1:08 AM

Abandoned as per @ngie's wishes not to have too many divergences from the upstream test suite.