locate.updatedb: Revert to using cat to copy the db.
ClosedPublic
Actions

Authored by des on Oct 2 2024, 11:05 AM.

Details

Reviewers

glebius
kevans

Group Reviewers

Klara

Commits

rG46d52461bf36: locate.updatedb: Revert to using cat to copy the db.
rG26bd374e7268: locate.updatedb: Revert to using cat to copy the db.

Summary

This script is usually run unprivileged, so install fails to create a
temporary file while copying the finished database. Revert to using
cat, which can overwrite the existing file as it is usually owned by
the same user which is running the script.

Fixes: f62c1f3f8e91
MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Oct 2 2024, 11:05 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 2 2024, 11:05 AM

des requested review of this revision.Oct 2 2024, 11:05 AM

Harbormaster completed remote builds in B59683: Diff 144109.Oct 2 2024, 11:05 AM

kevans accepted this revision.Oct 2 2024, 12:00 PM

This revision is now accepted and ready to land.Oct 2 2024, 12:00 PM

Closed by commit rG26bd374e7268: locate.updatedb: Revert to using cat to copy the db. (authored by des). · Explain WhyOct 2 2024, 3:56 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG26bd374e7268: locate.updatedb: Revert to using cat to copy the db..

des added a commit: rG46d52461bf36: locate.updatedb: Revert to using cat to copy the db..Oct 6 2024, 11:07 AM

des mentioned this in rG8d65747f7c6f: locate.updatedb: Explicitly exit from trap code..

Revision Contents
Changeset List

Path

Size

usr.bin/

locate/

updatedb.sh

2 lines

Diff 144130

View Options

usr.bin/locate/locate/updatedb.sh

locate.updatedb: Revert to using cat to copy the db.ClosedPublicActions