Page MenuHomeFreeBSD

env: Check the status of stdout.
ClosedPublic

Authored by des on Oct 8 2024, 10:07 AM.
Tags
None
Referenced Files
F132274494: D47009.diff
Wed, Oct 15, 10:13 AM
Unknown Object (File)
Wed, Oct 8, 3:46 AM
Unknown Object (File)
Mon, Sep 29, 4:57 PM
Unknown Object (File)
Fri, Sep 26, 3:49 AM
Unknown Object (File)
Fri, Sep 26, 2:09 AM
Unknown Object (File)
Sun, Sep 21, 12:14 PM
Unknown Object (File)
Sun, Sep 21, 2:16 AM
Unknown Object (File)
Sat, Sep 20, 7:41 PM
Subscribers

Details

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Oct 8 2024, 10:07 AM
markj added inline comments.
usr.bin/env/tests/env_test.sh
134

The rest of the file puts opening braces on their own lines.

140

Does it make sense to sleep for a bit first, to make sure that the other end of the pipe has time to close? Maybe I'm missing something, but this looks like it might fail only sometimes.

usr.bin/env/tests/env_test.sh
134

Yeah sorry this was copy-pasted from asa.

140

It works 100% of the time, we use the exact same procedure several other places (including asa which is where I copied this from). Timing doesn't matter because none of the output is consumed and the kernel doesn't buffer it.

This revision is now accepted and ready to land.Oct 8 2024, 1:45 PM
This revision now requires review to proceed.Oct 8 2024, 1:48 PM
des marked 2 inline comments as done.Oct 8 2024, 1:49 PM
This revision is now accepted and ready to land.Oct 8 2024, 4:59 PM
This revision was automatically updated to reflect the committed changes.