libsamplerate: Only build when virtual_oss is built
AcceptedPublic
Actions

Authored by ivy on Mon, Mar 30, 2:05 PM.

Details

Reviewers

christos
emaste

Group Reviewers

pkgbase

Summary

libsamplerate: Only build when virtual_oss is built

Gate libsamplerate behind MK_CUSE and MK_SOUND, like virtual_oss.
Nothing else uses this library, so there's no point building it
if we aren't building virtual_oss.

This avoids building a useless FreeBSD-sound package containing
only this library when WITHOUT_SOUND is set.

MFC after:      1 week
Sponsored by:   https://www.patreon.com/bsdivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71850
Build 68733: arc lint + arc unit

Event Timeline

ivy created this revision.Mon, Mar 30, 2:05 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Mar 30, 2:05 PM

ivy requested review of this revision.Mon, Mar 30, 2:05 PM

Harbormaster completed remote builds in B71825: Diff 174545.Mon, Mar 30, 2:05 PM

ivy added a child revision: D56087: packages: Convert world to a subdir build.Mon, Mar 30, 2:05 PM

emaste added a subscriber: emaste.Mon, Mar 30, 2:06 PM

emaste added inline comments.

lib/Makefile
239	could it go here instead? it's only used by virtual_oss I think?

ivy added inline comments.Mon, Mar 30, 2:08 PM

lib/Makefile
239	that would also be fine, if christos has no objection.

Thanks for this patch. I agree with Ed's comment.

ivy retitled this revision from libsamplerate: Don't build if WITHOUT_SOUND is set to libsamplerate: Only build when virtual_oss is built.Tue, Mar 31, 8:10 AM

ivy edited the summary of this revision. (Show Details)

also gate behind MK_CUSE, to match virtual_oss

Harbormaster completed remote builds in B71850: Diff 174606.Tue, Mar 31, 8:10 AM

i'm testing this now (which takes ~5 hours since i have to run two full builds) but i think it's correct :-)

emaste accepted this revision.Tue, Mar 31, 12:27 PM

This revision is now accepted and ready to land.Tue, Mar 31, 12:27 PM

christos accepted this revision.Tue, Mar 31, 12:32 PM