libsamplerate: Only build when virtual_oss is built
ClosedPublic
Actions

Authored by ivy on Mar 30 2026, 2:05 PM.

Details

Reviewers

christos
emaste

Group Reviewers

pkgbase

Commits

rGc4f66ede12d3: libsamplerate: Only build when virtual_oss is built
rGbaa7a870d65d: libsamplerate: Only build when virtual_oss is built

Summary

libsamplerate: Only build when virtual_oss is built

Gate libsamplerate behind MK_CUSE and MK_SOUND, like virtual_oss.
Nothing else uses this library, so there's no point building it
if we aren't building virtual_oss.

This avoids building a useless FreeBSD-sound package containing
only this library when WITHOUT_SOUND is set.

MFC after:      1 week
Sponsored by:   https://www.patreon.com/bsdivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71850
Build 68733: arc lint + arc unit

Event Timeline

ivy created this revision.Mar 30 2026, 2:05 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 30 2026, 2:05 PM

ivy requested review of this revision.Mar 30 2026, 2:05 PM

Harbormaster completed remote builds in B71825: Diff 174545.Mar 30 2026, 2:05 PM

ivy added a child revision: D56087: packages: Convert world to a subdir build.Mar 30 2026, 2:05 PM

emaste added a subscriber: emaste.Mar 30 2026, 2:06 PM

emaste added inline comments.

lib/Makefile
239	could it go here instead? it's only used by virtual_oss I think?

ivy added inline comments.Mar 30 2026, 2:08 PM

lib/Makefile
239	that would also be fine, if christos has no objection.

Thanks for this patch. I agree with Ed's comment.

ivy retitled this revision from libsamplerate: Don't build if WITHOUT_SOUND is set to libsamplerate: Only build when virtual_oss is built.Mar 31 2026, 8:10 AM

ivy edited the summary of this revision. (Show Details)

also gate behind MK_CUSE, to match virtual_oss

Harbormaster completed remote builds in B71850: Diff 174606.Mar 31 2026, 8:10 AM

i'm testing this now (which takes ~5 hours since i have to run two full builds) but i think it's correct :-)

emaste accepted this revision.Mar 31 2026, 12:27 PM

This revision is now accepted and ready to land.Mar 31 2026, 12:27 PM

christos accepted this revision.Mar 31 2026, 12:32 PM

Closed by commit rGbaa7a870d65d: libsamplerate: Only build when virtual_oss is built (authored by ivy). · Explain WhyApr 3 2026, 1:51 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGbaa7a870d65d: libsamplerate: Only build when virtual_oss is built.

ivy added a commit: rGc4f66ede12d3: libsamplerate: Only build when virtual_oss is built.Apr 7 2026, 11:27 AM