Page MenuHomeFreeBSD

Remove WITHOUT_BZIP2, WITHOUT_BZIP2_SUPPORT
ClosedPublic

Authored by ivy on Sun, Mar 29, 8:06 PM.
Tags
None
Referenced Files
F150645496: D56148.id.diff
Fri, Apr 3, 1:44 AM
Unknown Object (File)
Thu, Apr 2, 9:16 PM
Unknown Object (File)
Wed, Apr 1, 5:18 PM

Details

Summary

WITHOUT_BZIP2_SUPPORT only affects a single binary, gzip(1); it doesn't
remove bzip2 support from other bits (e.g., libarchive) and there are
no similar options for gzip, xz or zstd.

WITHOUT_BZIP2 has not done anything at all since it was first added
in 2007.

MFC after: never
Discussed on: arch@
Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy requested review of this revision.Sun, Mar 29, 8:06 PM
This revision is now accepted and ready to land.Sun, Mar 29, 8:41 PM

Should be mentioned in relnotes.

i'll update RELNOTES after landing (i wish this didn't need to be a two-step process...)

(Personally I think it's probably better to expand WITHOUT_BZIP2 support to other utilities, as bzip2 is largely in maintenance mode and we might want to remove it eventually, but I don't have strong opinion either way).

I'm not sure you need to bother with RELNOTES since neither of these options were ever much (or any) use.

I guess that since it didn't do much of anything RELNOTES does not much matter, but I think we ought to note when any option is removed. It may be that UPDATING is the more appropriate spot?

i think it's okay to list src.conf changes in relnotes. there aren't very many of them, and it's the sort of thing users might want to know there -- there are some much less interesting things listed in relnotes.

(unless people think relnotes is too long already, in which case i could be persuaded not to put this in there; i don't really have a strong opinion on it.)

This revision was automatically updated to reflect the committed changes.