Page MenuHomeFreeBSD

etc/mtree/BSD.include.dist: Remove bsnmp tags
ClosedPublic

Authored by manu on Mon, Dec 15, 3:19 PM.

Details

Summary

When building with WITHOUT_BSNMP this result in a FreeBSD-bsnmp-dev
package with only this directory and a dependency on FreeBSD-bsnmp which
doesn't exists.

Fixes: 436618a427b4 ("etc/mtree: Add package tags for /usr/include")
Sponsored by: Beckhoff Automation GMbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu requested review of this revision.Mon, Dec 15, 3:19 PM

I wonder if changing it to: tags=package=bsnmp,dev solves the issue?

I wonder if changing it to: tags=package=bsnmp,dev solves the issue?

no. the package we're building is correct according to the mtree: this directory should be in bsnmp-dev.

the problem is that if you don't build the rest of bsnmp:

  • you end up with a package containing this (empty) directory and nothing else, which is useless
  • the package can't be installed anyway (which breaks system installation) because -dev packages get an automatic dependency on their base package, but there is no base package, because we didn't build bsnmp

since there's no way to include conditional logic in mtree files, the proper fix for this will probably be to just not build packages which only contain directories and nothing else, at which point we can revert the recent fixes to BSD.include.dist.

This revision is now accepted and ready to land.Mon, Dec 15, 5:35 PM
This revision was automatically updated to reflect the committed changes.