Page MenuHomeFreeBSD

release: Improve error handling and option logic
Needs ReviewPublic

Authored by ivy on Tue, Jan 6, 1:46 AM.
Tags
None
Referenced Files
F141878668: D54548.diff
Sun, Jan 11, 9:46 PM
Unknown Object (File)
Sat, Jan 10, 6:33 AM
Unknown Object (File)
Sat, Jan 10, 12:04 AM
Unknown Object (File)
Fri, Jan 9, 9:26 AM
Unknown Object (File)
Tue, Jan 6, 6:44 PM
Unknown Object (File)
Tue, Jan 6, 11:26 AM
Unknown Object (File)
Tue, Jan 6, 9:29 AM
Unknown Object (File)
Tue, Jan 6, 9:08 AM
Subscribers

Details

Reviewers
None
Group Reviewers
releng
Summary

Based on the user-provided options, define three internal variables,
_USE_PKG, _USE_PKGBASE and _USE_PORTS, to avoid having to repeat the
hard-to-read "!defined(X) || empty(X)" conditional in many places.

Add some early errors for things we know don't work, like using pkg
on non-FreeBSD platforms.

Stop ignoring errors when installing packages onto the media; if this
fails and the user is okay with that, they should set NOPKG to avoid
trying it in the first place. This avoids silently building media
which is missing expected components.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69643
Build 66526: arc lint + arc unit