Differential D54548

release: Improve error handling and option logic
Needs ReviewPublic
Actions

Authored by ivy on Jan 6 2026, 1:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 15, 8:56 AM

	Unknown Object (File)
	Sat, Apr 11, 7:58 PM

	Unknown Object (File)
	Wed, Apr 8, 9:48 AM

	Unknown Object (File)
	Sat, Apr 4, 11:59 AM

	Unknown Object (File)
	Wed, Apr 1, 8:08 PM

	Unknown Object (File)
	Wed, Apr 1, 6:21 AM

	Unknown Object (File)
	Sat, Mar 28, 3:59 AM

	Unknown Object (File)
	Wed, Mar 18, 6:01 PM

View All 28 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Summary

Based on the user-provided options, define three internal variables,
_USE_PKG, _USE_PKGBASE and _USE_PORTS, to avoid having to repeat the
hard-to-read "!defined(X) || empty(X)" conditional in many places.

Add some early errors for things we know don't work, like using pkg
on non-FreeBSD platforms.

Stop ignoring errors when installing packages onto the media; if this
fails and the user is okay with that, they should set NOPKG to avoid
trying it in the first place. This avoids silently building media
which is missing expected components.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69643
Build 66526: arc lint + arc unit

Event Timeline

ivy created this revision.Jan 6 2026, 1:46 AM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptJan 6 2026, 1:46 AM

ivy requested review of this revision.Jan 6 2026, 1:46 AM

Harbormaster completed remote builds in B69643: Diff 169146.Jan 6 2026, 1:46 AM

ivy added a parent revision: D54546: release: Keep the pkg build in OBJDIR.Jan 6 2026, 1:46 AM

ivy added a child revision: D54282: packages: Always install kernel as /boot/kernel.NAME.Jan 6 2026, 11:09 PM

This seems like a good idea to me; will take a detailed look soon. Patch needs to be rebased.

In D54548#1286203, @emaste wrote:

This seems like a good idea to me; will take a detailed look soon. Patch needs to be rebased.

this entire stack is stalled until we can get some consensus on D54282. i'm working on other pkgbase things in the mean time.

Revision Contents
Changeset List

Path

Size

release/

125 lines

Diff 169146

release/Makefile

Loading...