Page MenuHomeFreeBSD

libcrypto: move engines and modules to openssl-lib
ClosedPublic

Authored by ivy on May 4 2025, 10:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 24, 12:59 AM
Unknown Object (File)
Mon, Sep 22, 2:20 PM
Unknown Object (File)
Sun, Sep 21, 1:31 PM
Unknown Object (File)
Sat, Sep 20, 8:40 AM
Unknown Object (File)
Thu, Sep 18, 12:39 AM
Unknown Object (File)
Wed, Sep 17, 7:43 AM
Unknown Object (File)
Mon, Sep 15, 11:17 PM
Unknown Object (File)
Sep 15 2025, 5:28 PM
Subscribers

Details

Summary

currently, some OpenSSL-related files end up in the utilities package:

/usr/lib/engines-3/capi.so
/usr/lib/engines-3/devcrypto.so
/usr/lib/engines-3/loader_attic.so
/usr/lib/engines-3/padlock.so
/usr/lib/ossl-modules/legacy.so

since these are part of OpenSSL and are not useful without it, move them
to the openssl-lib package.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy requested review of this revision.May 4 2025, 10:56 AM
This revision is now accepted and ready to land.May 4 2025, 7:44 PM

I'm uneasy with the name of this new package; it sounds like it should contain the openssl library, but it doesn't. Can we name it openssl-engines instead?

In D50144#1144184, @des wrote:

I'm uneasy with the name of this new package; it sounds like it should contain the openssl library, but it doesn't.

but it does:

% pkg info -l freebsd-openssl-lib
FreeBSD-openssl-lib-15.snap20250504111358:
        /lib/libcrypto.so.30
        /usr/lib/libssl.so.30

i think what happened here is someone added PACKAGE=openssl-lib to secure/lib/libcrypto/Makefile and assumed it would be recursive, but it's not, you have to set it in every subdir as well.

My mistake, I thought this was a new package just for the engines.

secure/lib/libcrypto/engines/capi/Makefile
1 ↗(On Diff #154785)

We discussed out-of-band moving the default PACKAGE to engines/Makefile.inc (and the below to modules/Makefile.inc) to remove a bit of redundancy.

use Makefile.inc to do this instead

This revision now requires review to proceed.May 5 2025, 9:38 PM
This revision is now accepted and ready to land.May 5 2025, 9:47 PM