fwget: pci_intel_video: do no log on no match
ClosedPublic
Actions

Authored by bz on Jun 18 2025, 4:53 PM.

Details

Reviewers

manu
bapt
dumbbell
emaste

Commits

rGc87176dd16ab: fwget: pci_intel_video: do no log on no match
rGf1f71cc717aa: fwget: pci_intel_video: do no log on no match

Summary

We should never log a statement on no match for a given device we
do nto know about. We do not control the PCI assignments and thus
cannot predict if we would even support such a device.

This also triggers an invalid output in the installer.

Leave it as log-vebose for now.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
PR: 287639

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Jun 18 2025, 4:53 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 18 2025, 4:53 PM

bz requested review of this revision.Jun 18 2025, 4:53 PM

Harbormaster completed remote builds in B64952: Diff 157261.Jun 18 2025, 4:53 PM

bz edited the summary of this revision. (Show Details)Jun 18 2025, 4:54 PM

bz added a subscriber: emaste.

manu accepted this revision.Jun 18 2025, 6:02 PM

This revision is now accepted and ready to land.Jun 18 2025, 6:02 PM

emaste accepted this revision.Jun 18 2025, 6:06 PM

Closed by commit rGf1f71cc717aa: fwget: pci_intel_video: do no log on no match (authored by bz). · Explain WhyJun 18 2025, 11:31 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGf1f71cc717aa: fwget: pci_intel_video: do no log on no match.

bz added a commit: rGc87176dd16ab: fwget: pci_intel_video: do no log on no match.Jul 13 2025, 7:31 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

fwget/

pci/

pci_video_intel

2 lines

Diff 157283

View Options

usr.sbin/fwget/pci/pci_video_intel

fwget: pci_intel_video: do no log on no matchClosedPublicActions