Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

manu added inline comments to D36138: Add RockChip RK356X support to existing RockChip iodomain driver.
Thu, Aug 11, 1:40 PM
manu added inline comments to D36138: Add RockChip RK356X support to existing RockChip iodomain driver.
Thu, Aug 11, 1:23 PM
manu added a comment to D36138: Add RockChip RK356X support to existing RockChip iodomain driver.

VCCIO2 voltage can also be controlled by GPIO_0A7 and this is the default.
It seems that Linux doesn't do anything for this iodomain, might be a good idea to do the same here.

Thu, Aug 11, 8:55 AM
manu added a comment to D36138: Add RockChip RK356X support to existing RockChip iodomain driver.

This isn't correct.
There is no need for sc->conf->type here, we need to expand the struct rk_iodomain_supply to have the corresponding registers.
The if (i == 1) is wrong, we need to write to the corresponding register for each iodomain in the dts.
One should be careful doing there is multiple bits on multiple register for choosing the output voltage, we need to disable all of them and then enable the correct voltage based on the regulator value. There is three value possible, 1.8V, 2.5v and 3.3v (but not for every iodomain).
Have a look at page 208 of the TRM Part1 to have a better idea on how this is supposed to work.

Thu, Aug 11, 8:47 AM
manu abandoned D32497: graphics/gpu-firmware-gpu: Rework the ports to be a metaport.

Commited a while ago.

Thu, Aug 11, 7:55 AM
manu updated the diff for D36106: linuxkpi: Add dma_{un,}map_sgtable.

Use dma_unmap_sg_attrs in dma_unmap_sgtable

Thu, Aug 11, 7:54 AM
manu added a comment to D36105: linuxkpi: Add linux/stackdepot.h.
In D36105#819924, @bz wrote:

From the use in drm __topology_ref_save it seems it could be more than one value as it loops over them and compares them to find an entry? So not sure if "bool" is correct?

Thu, Aug 11, 7:45 AM
manu updated the diff for D36101: linuxkpi: pgtable: Add more defines.

Only add the defines for x86 as it's x86 related.

Thu, Aug 11, 7:42 AM
manu updated the diff for D36107: linuxkpi: Add asm/processor.h.

Guard the include for x86 machines only

Thu, Aug 11, 7:40 AM
manu updated the diff for D36102: linuxkpi: acpi/video.h: Add stubs acpi_video_{register,unregister}.

Switch to inline function and return -ENODEV for the register one.

Thu, Aug 11, 7:39 AM
manu added inline comments to D36138: Add RockChip RK356X support to existing RockChip iodomain driver.
Thu, Aug 11, 7:17 AM
manu accepted D36137: Add RockChip RK356X support to existing RockChip thermal driver .
Thu, Aug 11, 7:13 AM

Wed, Aug 10

manu committed rG348164aa9e5d: sdio: Add CCCR speed defines (authored by manu).
sdio: Add CCCR speed defines
Wed, Aug 10, 8:08 PM
manu committed rG1ee7a8049218: sdio: Always use increment address for read/write_4 (authored by manu).
sdio: Always use increment address for read/write_4
Wed, Aug 10, 8:08 PM
manu committed rG49da0242e798: sdio: Do not allow setting a block size if function doesn't support it (authored by manu).
sdio: Do not allow setting a block size if function doesn't support it
Wed, Aug 10, 8:08 PM
manu committed rGb9db5e0a8f38: sdio: Change the sdio helper name and arg order (authored by manu).
sdio: Change the sdio helper name and arg order
Wed, Aug 10, 8:08 PM
manu added a comment to D36101: linuxkpi: pgtable: Add more defines.
In D36101#819960, @bz wrote:

I do not have enough ideas about this but given it is not wrapped in amd64 and i386 I wonder if we (a) should do that or (b) what @andrew thinks about this?

Wed, Aug 10, 5:47 PM
manu added inline comments to D36112: linuxkpi: Add add_taint stub.
Wed, Aug 10, 5:46 PM
manu added inline comments to D36099: linuxkpi: Add refcount_dec_and_test.
Wed, Aug 10, 5:45 PM
manu committed rGd38a784b61e3: modules: if_awg: Add miibus_if.h to the source (authored by manu).
modules: if_awg: Add miibus_if.h to the source
Wed, Aug 10, 5:26 PM
manu committed rGfbc50a695433: modules: aw_mmc: Add mmc_pwrseq_if to the source (authored by manu).
modules: aw_mmc: Add mmc_pwrseq_if to the source
Wed, Aug 10, 5:26 PM
manu committed rG87f642ac03e3: arm64: rockchip: rk_gpio: Improve mode switching (authored by manu).
arm64: rockchip: rk_gpio: Improve mode switching
Wed, Aug 10, 5:23 PM
manu added inline comments to D36027: Rudimentary RockChip RK356X support.
Wed, Aug 10, 4:55 PM
manu added inline comments to D36102: linuxkpi: acpi/video.h: Add stubs acpi_video_{register,unregister}.
Wed, Aug 10, 3:57 PM
manu added inline comments to D36099: linuxkpi: Add refcount_dec_and_test.
Wed, Aug 10, 3:54 PM
manu committed rG8d6b3a857010: arm64: rockchip: pinctrl: Do not rely on the node name (authored by manu).
arm64: rockchip: pinctrl: Do not rely on the node name
Wed, Aug 10, 1:50 PM
manu committed rGc9ccf3a32da4: Import device-tree files from Linux 5.18 (authored by manu).
Import device-tree files from Linux 5.18
Wed, Aug 10, 12:34 PM
manu committed rG9066e824cab7: Import device-tree files from Linux 5.18 (authored by manu).
Import device-tree files from Linux 5.18
Wed, Aug 10, 12:33 PM
manu committed rGe67e85659c0d: Import device-tree files from Linux 5.17 (authored by manu).
Import device-tree files from Linux 5.17
Wed, Aug 10, 12:31 PM
manu committed rGb7d8b5635a26: Import device-tree files from Linux 5.17 (authored by manu).
Import device-tree files from Linux 5.17
Wed, Aug 10, 12:30 PM
manu committed rG8cc087a1eee9: Import device-tree files from Linux 5.16 (authored by manu).
Import device-tree files from Linux 5.16
Wed, Aug 10, 12:29 PM
manu committed rGdec44e532c3b: Import device-tree files from Linux 5.16 (authored by manu).
Import device-tree files from Linux 5.16
Wed, Aug 10, 12:27 PM
manu committed rG354d7675fe12: Import device-tree files from Linux 5.15 (authored by manu).
Import device-tree files from Linux 5.15
Wed, Aug 10, 12:23 PM
manu committed rG1769b8f3a9ff: Import device-tree files from Linux 5.15 (authored by manu).
Import device-tree files from Linux 5.15
Wed, Aug 10, 12:22 PM
manu committed rG5956d97f4b32: Import device-tree files from Linux 5.14 (authored by manu).
Import device-tree files from Linux 5.14
Wed, Aug 10, 12:20 PM
manu committed rG17bac45f172c: Import device-tree files from Linux 5.14 (authored by manu).
Import device-tree files from Linux 5.14
Wed, Aug 10, 12:09 PM
manu added inline comments to D36027: Rudimentary RockChip RK356X support.
Wed, Aug 10, 9:41 AM
manu requested review of D36113: linuxkpi: Add __copy_to_user_inatomic and __copy_from_user_inatomic.
Wed, Aug 10, 6:50 AM
manu requested review of D36112: linuxkpi: Add add_taint stub.
Wed, Aug 10, 6:50 AM
manu requested review of D36111: linuxkpi: Add few more include in linux/kernel.h.
Wed, Aug 10, 6:49 AM
manu requested review of D36110: linuxkpi: Add a bunch of dummy include.
Wed, Aug 10, 6:49 AM
manu requested review of D36109: linuxkpi: swap.h: Fix include.
Wed, Aug 10, 6:49 AM
manu requested review of D36108: linuxkpi: Add stub kmem_cache_shrink.
Wed, Aug 10, 6:49 AM
manu requested review of D36107: linuxkpi: Add asm/processor.h.
Wed, Aug 10, 6:48 AM
manu requested review of D36106: linuxkpi: Add dma_{un,}map_sgtable.
Wed, Aug 10, 6:48 AM
manu requested review of D36105: linuxkpi: Add linux/stackdepot.h.
Wed, Aug 10, 6:48 AM
manu requested review of D36104: linuxkpi: Add linux/vgaarg.h.
Wed, Aug 10, 6:47 AM
manu requested review of D36103: linuxkpi: Add video/mipi_display.h.
Wed, Aug 10, 6:47 AM
manu requested review of D36102: linuxkpi: acpi/video.h: Add stubs acpi_video_{register,unregister}.
Wed, Aug 10, 6:47 AM
manu requested review of D36101: linuxkpi: pgtable: Add more defines.
Wed, Aug 10, 6:47 AM
manu requested review of D36100: linuxkpi: Add sched/mm.h.
Wed, Aug 10, 6:46 AM
manu requested review of D36099: linuxkpi: Add refcount_dec_and_test.
Wed, Aug 10, 6:46 AM
manu requested review of D36098: linuxkpi: Add for_each_sgtable_{sg,page}.
Wed, Aug 10, 6:46 AM

Tue, Aug 9

manu committed rG821b850a3bb7: x86: Remove redundant parentheses (authored by manu).
x86: Remove redundant parentheses
Tue, Aug 9, 7:49 AM
manu committed rGb223c1f1a0ac: x86: Add another cpuid for Apollo Lake errata APL30 (authored by c.koehne_beckhoff.com).
x86: Add another cpuid for Apollo Lake errata APL30
Tue, Aug 9, 7:09 AM

Mon, Aug 8

manu committed rG521abc32e22a: linuxkpi: io.h: Only exclude armv6 and armv7 for asm/set_memory.h (authored by manu).
linuxkpi: io.h: Only exclude armv6 and armv7 for asm/set_memory.h
Mon, Aug 8, 6:23 PM
manu committed rGd387a1b4b199: linuxkpi: io.h: Do not include asm/set_memory.h for armv6 and armv7 (authored by manu).
linuxkpi: io.h: Do not include asm/set_memory.h for armv6 and armv7
Mon, Aug 8, 4:56 PM
manu committed R11:1ef64bc6e23c: graphics/drm-510-kmod: Update to drm_v5.10.113_3 (authored by manu).
graphics/drm-510-kmod: Update to drm_v5.10.113_3
Mon, Aug 8, 2:14 PM
manu committed rGb273f93657cf: Bump __FreeBSD_version after linuxkpi changes. (authored by manu).
Bump __FreeBSD_version after linuxkpi changes.
Mon, Aug 8, 2:07 PM
manu committed rG2ff0f051498a: linuxkpi: pm: Add more defines and includes (authored by manu).
linuxkpi: pm: Add more defines and includes
Mon, Aug 8, 2:07 PM
manu committed rG789dbdbb4857: linuxkpi: Add arch_io_{reserve,free}_memtype_wc (authored by manu).
linuxkpi: Add arch_io_{reserve,free}_memtype_wc
Mon, Aug 8, 2:07 PM
manu committed rGb829f450a7a3: linuxkpi: Include highmem.h in pagemap.h (authored by manu).
linuxkpi: Include highmem.h in pagemap.h
Mon, Aug 8, 2:07 PM
manu committed rGa7727e1a6d5d: linuxkpi: Add dev_info_once (authored by manu).
linuxkpi: Add dev_info_once
Mon, Aug 8, 2:07 PM
manu committed rGeca2f0f38066: linuxkpi: Add smp_mb__before/after_atomic (authored by manu).
linuxkpi: Add smp_mb__before/after_atomic
Mon, Aug 8, 2:07 PM
manu committed rGd1c3cfd79da1: linuxkpi: Add trylock_page and unlock_page (authored by manu).
linuxkpi: Add trylock_page and unlock_page
Mon, Aug 8, 2:07 PM
manu committed rG7d2702a19839: linuxkpi: Add more notifier defines (authored by manu).
linuxkpi: Add more notifier defines
Mon, Aug 8, 2:07 PM
manu committed rG2d4b17685fd2: linuxkpi: errno: Add EHWPOISON (authored by manu).
linuxkpi: errno: Add EHWPOISON
Mon, Aug 8, 2:07 PM
manu closed D36024: linuxkpi: pm: Add more defines and includes.
Mon, Aug 8, 2:07 PM
manu committed rG37cda2837c00: linuxkpi: Add compat_ptr and ptr_to_compat (authored by manu).
linuxkpi: Add compat_ptr and ptr_to_compat
Mon, Aug 8, 2:07 PM
manu closed D36023: linuxkpi: Include highmem.h in pagemap.h.
Mon, Aug 8, 2:07 PM
manu closed D36022: linuxkpi: Add arch_io_{reserve,free}_memtype_wc.
Mon, Aug 8, 2:07 PM
manu committed rG39da3678b1ce: linuxkpi: Add try_cmpxchg and atomic_try_cmpxchg (authored by manu).
linuxkpi: Add try_cmpxchg and atomic_try_cmpxchg
Mon, Aug 8, 2:07 PM
manu closed D36021: linuxkpi: Add dev_info_once.
Mon, Aug 8, 2:07 PM
manu committed rGfa1f02baafd3: linuxkpi: Add some memset functions (authored by manu).
linuxkpi: Add some memset functions
Mon, Aug 8, 2:07 PM
manu closed D36020: linuxkpi: Add smp_mb__before/after_atomic.
Mon, Aug 8, 2:07 PM
manu closed D36019: linuxkpi: Add trylock_page and unlock_page.
Mon, Aug 8, 2:07 PM
manu committed rG96b917bfcf2c: linuxkpi: Add io.h (authored by manu).
linuxkpi: Add io.h
Mon, Aug 8, 2:07 PM
manu closed D36018: linuxkpi: Add more notifier defines.
Mon, Aug 8, 2:07 PM
manu closed D36017: linuxkpi: errno: Add EHWPOISON.
Mon, Aug 8, 2:07 PM
manu closed D36016: linuxkpi: Add compat_ptr and ptr_to_compat.
Mon, Aug 8, 2:07 PM
manu closed D36015: linuxkpi: Add try_cmpxchg and atomic_try_cmpxchg.
Mon, Aug 8, 2:06 PM
manu committed rGa0c171328f66: linuxkpi: Add pagevec implementation (authored by manu).
linuxkpi: Add pagevec implementation
Mon, Aug 8, 2:06 PM
manu closed D35943: linuxkpi: Add some memset functions.
Mon, Aug 8, 2:06 PM
manu closed D35942: linuxkpi: Add io.h.
Mon, Aug 8, 2:06 PM
manu closed D35941: linuxkpi: Add pagevec implementation.
Mon, Aug 8, 2:06 PM
manu closed D35940: linuxkpi: Add linux/nospec.h.
Mon, Aug 8, 2:06 PM
manu committed rGaec6a64c68b9: linuxkpi: Add linux/nospec.h (authored by manu).
linuxkpi: Add linux/nospec.h
Mon, Aug 8, 2:06 PM
manu closed D35939: linuxkpi: Add mapping_clear_unevictable stub.
Mon, Aug 8, 2:06 PM
manu committed rG4aa82e4358c0: linuxkpi: Add mapping_clear_unevictable stub (authored by manu).
linuxkpi: Add mapping_clear_unevictable stub
Mon, Aug 8, 2:06 PM
manu closed D35938: linuxkpi: pci: Add more functions needed by drm.
Mon, Aug 8, 2:05 PM
manu committed rG6890e327a86d: linuxkpi: pci: Add more functions needed by drm (authored by manu).
linuxkpi: pci: Add more functions needed by drm
Mon, Aug 8, 2:05 PM
manu closed D35937: linuxkpi: math.h: Add mul_u64_u32_div and mul_u64_u32_shr.
Mon, Aug 8, 2:05 PM
manu committed rG885ab0dba28b: linuxkpi: math.h: Add mul_u64_u32_div and mul_u64_u32_shr (authored by manu).
linuxkpi: math.h: Add mul_u64_u32_div and mul_u64_u32_shr
Mon, Aug 8, 2:05 PM
manu closed D35936: linuxkpi: atomic: Add atomic_fetch_inc.
Mon, Aug 8, 2:04 PM
manu committed rG6be89cc88d63: linuxkpi: atomic: Add atomic_fetch_inc (authored by manu).
linuxkpi: atomic: Add atomic_fetch_inc
Mon, Aug 8, 2:04 PM

Fri, Aug 5

manu updated the diff for D36015: linuxkpi: Add try_cmpxchg and atomic_try_cmpxchg.

Switch to __typeof

Fri, Aug 5, 7:49 AM
manu updated the diff for D36016: linuxkpi: Add compat_ptr and ptr_to_compat.

Switch to uintptr_t

Fri, Aug 5, 7:48 AM
manu updated the diff for D36021: linuxkpi: Add dev_info_once.

Address comments from @emaste

Fri, Aug 5, 7:47 AM

Thu, Aug 4

manu added a comment to D36027: Rudimentary RockChip RK356X support.

Would you mind splitting this review into multiple one ?

Thu, Aug 4, 8:37 AM

Wed, Aug 3

manu accepted D36028: pkgbase: split kerberos binaries and libs.

LGTM, please add in the commit message that sshd is one of those binaries that one might want to install without having all the kerberos binaries pulled in.

Wed, Aug 3, 9:04 AM