Page MenuHomeFreeBSD
Differential D53546

mmc_fdt: handle broken-cd property
ClosedPublic
Actions

Authored by mhorne on Mon, Nov 3, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 4, 7:07 AM
Unknown Object (File)
Tue, Nov 4, 5:05 AM
Unknown Object (File)
Tue, Nov 4, 1:37 AM
Unknown Object (File)
Mon, Nov 3, 11:53 PM
Unknown Object (File)
Mon, Nov 3, 11:50 PM
Unknown Object (File)
Mon, Nov 3, 11:40 PM
Unknown Object (File)
Mon, Nov 3, 7:34 PM
Unknown Object (File)
Mon, Nov 3, 7:30 PM
Subscribers
gehaowu_bitmoe.com
loos

Details

Reviewers
manu
imp
mmel
andrew
gehaowu_bitmoe.com
Commits
rG768ee6d45482: mmc_fdt: handle broken-cd property
Summary

The documented properties [1] for card-detection are one of:

  • cd-gpios
  • non-removable
  • broken-cd

In cd_setup() we handle the first two, but not the latter, resulting in
a silently undetected card on an affected system.

To work around this, force cd_disabled when broken-cd is specified, so
that the card detect helper function gets to run. A more complete
solution would implement some kind of polling mechanism to detect the
card's presence or removal.

Some variants of the Allwinner D1, such as the Lichee Rv, specify this
property in the mmc0 device node.

[1] sys/contrib/device-tree/Bindings/mmc/mmc-controller.yaml

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Mon, Nov 3, 3:18 PM
Herald added a reviewer: andrew. · View Herald TranscriptMon, Nov 3, 3:18 PM
Herald added a subscriber: loos. · View Herald Transcript
mhorne requested review of this revision.Mon, Nov 3, 3:18 PM
Harbormaster completed remote builds in B68370: Diff 165729.Mon, Nov 3, 3:18 PM
mhorne added a comment.Mon, Nov 3, 3:21 PM

Most likely, this same treatment should be applied to the similar cd_detect() function in sys/dev/sdhci/sdhci_fdt_gpio.c.

However, I don't have any device with which to test the sdhci fdt driver.

imp accepted this revision.Mon, Nov 3, 9:56 PM
This revision is now accepted and ready to land.Mon, Nov 3, 9:56 PM
mmel accepted this revision.Tue, Nov 4, 8:01 PM
gehaowu_bitmoe.com accepted this revision.Wed, Nov 5, 12:23 AM
gehaowu_bitmoe.com added a subscriber: gehaowu_bitmoe.com.

I've tested it on the Lichee RV Dock, and it boots the system properly. Thanks to mhorne.

manu accepted this revision.Wed, Nov 5, 6:48 AM
Closed by commit rG768ee6d45482: mmc_fdt: handle broken-cd property (authored by mhorne). · Explain WhyWed, Nov 5, 2:41 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG768ee6d45482: mmc_fdt: handle broken-cd property.

Revision Contents
Changeset List

PathSize
sys/
dev/
mmc/
11 lines

Diff 165873

View Options

sys/dev/mmc/mmc_fdt_helpers.c

Loading...