libc: Move NLS catalogues to the locales packages
ClosedPublic
Actions

Authored by ivy on Fri, Oct 3, 11:12 PM.

Details

Reviewers

kib
manu

Group Reviewers

pkgbase

Commits

rGcfcd89e6cc15: libc: Move NLS catalogues to the locales packages
rG0242d4c3aea4: libc: Move NLS catalogues to the locales packages

Summary

We don't want to put these in clibs (where libc is) since they are not
critical to system operation. Move them to locales, since anyone who
is interested in translated versions of strerror() is going to have
that installed anyway.

MFC after: 30 deciseconds

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Fri, Oct 3, 11:12 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 3, 11:12 PM

ivy requested review of this revision.Fri, Oct 3, 11:12 PM

Harbormaster completed remote builds in B67537: Diff 163503.Fri, Oct 3, 11:12 PM

manu accepted this revision.Sat, Oct 4, 5:55 AM

This revision is now accepted and ready to land.Sat, Oct 4, 5:55 AM

kib added inline comments.Sat, Oct 4, 9:28 AM

lib/libc/nls/Makefile.inc
18	How this variable supposed to work? I looked for it in non-patched sources and did not found any mention.

ivy added inline comments.Sat, Oct 4, 10:20 AM

lib/libc/nls/Makefile.inc
18	`${NLS}` is implemented as a files group in `bsd.nls.mk`: FILESGROUPS?= FILES FILESGROUPS+= NLS NLSDIR?= ${SHAREDIR}/nls this means we can use all the per-group variables supported by `bsd.files.mk`, including `${<groupname>PACKAGE}`, which in this case happens to expand to `${NLSPACKAGE}`.