Page MenuHomeFreeBSD
Differential D51211

Make NFS server aware of mnt_renamelock
ClosedPublic
Actions

Authored by kib on Jul 8 2025, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 10:05 AM
Unknown Object (File)
Sun, Oct 12, 10:05 AM
Unknown Object (File)
Sun, Oct 12, 10:05 AM
Unknown Object (File)
Sun, Oct 12, 10:05 AM
Unknown Object (File)
Sat, Oct 11, 11:11 PM
Unknown Object (File)
Sep 15 2025, 7:11 AM
Unknown Object (File)
Sep 14 2025, 9:55 AM
Unknown Object (File)
Sep 12 2025, 1:41 PM
View All 31 Files
Subscribers
imp
pho

Details

Reviewers
rmacklem
des
markj
Commits
rG6280d03bb5fd: nfsserver rename: lock mnt_renamelock as required
rG44e9c9f8f391: nfsvno_rename(): do not use -1 as special error indicator
Summary
nfsvno_rename(): do not use -1 as special error indicator

it clashes with ERESTART.  Use EJUSTRETURN for the case, as it is often
done in other places in the kernel.


nfsserver rename: lock mnt_renamelock as required

Fixes:  ef6ea91593ebff73e2fc201efd9f848b71c5a125
Reported by:    des

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Jul 8 2025, 7:57 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 8 2025, 7:57 PM
kib requested review of this revision.Jul 8 2025, 7:57 PM
des added a comment.Jul 8 2025, 8:12 PM

I can confirm the NFS server no longer crashes with this patch applied.

rmacklem accepted this revision.Jul 8 2025, 8:17 PM

Looks ok to me, but I don't know much about renamelock.

This revision is now accepted and ready to land.Jul 8 2025, 8:17 PM
kib added a subscriber: pho.Jul 8 2025, 8:57 PM

Peter, could you please run stress2 with the patch? I think it only makes sense to do so for nfs server part.

markj added inline comments.Jul 9 2025, 12:46 AM
sys/fs/nfsserver/nfs_nfsdport.c
1655–1657

The comment needs to be updated.

kib updated this revision to Diff 158197.Jul 9 2025, 1:05 AM
kib marked an inline comment as done.

Update comment.

This revision now requires review to proceed.Jul 9 2025, 1:05 AM
markj accepted this revision.Jul 9 2025, 3:53 PM
markj added inline comments.
sys/fs/nfsserver/nfs_nfsdport.c
1732
This revision is now accepted and ready to land.Jul 9 2025, 3:53 PM
Closed by commit rG6280d03bb5fd: nfsserver rename: lock mnt_renamelock as required (authored by kib). · Explain WhyJul 9 2025, 5:38 PM
This revision was automatically updated to reflect the committed changes.
kib marked an inline comment as done.
kib added a commit: rG6280d03bb5fd: nfsserver rename: lock mnt_renamelock as required.
kib added a commit: rG44e9c9f8f391: nfsvno_rename(): do not use -1 as special error indicator.

Revision Contents
Changeset List

PathSize
sys/
fs/
nfsserver/
25 lines

Diff 158229

View Options

sys/fs/nfsserver/nfs_nfsdport.c

Loading...