amd64: move efi_map_regs definition
ClosedPublic
Actions

Authored by vexeduxr on Jul 6 2025, 8:01 PM.

Details

Reviewers

kib
markj

Commits

rGe05999a8c5a9: amd64: move efi_map_regs definition

Summary

Since efi_map_regs is used in machdep.c, efirt being compiled as a
module causes it to be left undefined.

Noticed by: kib

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vexeduxr created this revision.Jul 6 2025, 8:01 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 6 2025, 8:01 PM

vexeduxr requested review of this revision.Jul 6 2025, 8:01 PM

Harbormaster completed remote builds in B65239: Diff 158064.Jul 6 2025, 8:01 PM

kib accepted this revision.Jul 6 2025, 8:59 PM

kib added inline comments.

sys/amd64/amd64/machdep.c
192

This revision is now accepted and ready to land.Jul 6 2025, 8:59 PM

Reword comment to make it clear what the variable is for

This revision now requires review to proceed.Jul 6 2025, 9:11 PM

Harbormaster completed remote builds in B65245: Diff 158072.Jul 6 2025, 9:11 PM

kib accepted this revision.Jul 6 2025, 9:19 PM

This revision is now accepted and ready to land.Jul 6 2025, 9:19 PM

Please be sure to include a Fixes: tag in the commit message.

Closed by commit rGe05999a8c5a9: amd64: move efi_map_regs definition (authored by vexeduxr). · Explain WhyJul 7 2025, 4:10 AM

This revision was automatically updated to reflect the committed changes.

vexeduxr added a commit: rGe05999a8c5a9: amd64: move efi_map_regs definition.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

efirt_machdep.c

2 lines

machdep.c

6 lines

Diff 158077

View Options

sys/amd64/amd64/efirt_machdep.c