inotify: do not call into namei() with a locked vnode
ClosedPublic
Actions

Authored by kib on Jul 10 2025, 7:17 AM.

Details

Reviewers

Commits

rGe8c54222acdb: inotify: do not call into namei() with a locked vnode
rG63389aea24f1: inotify: do not call into namei() with a locked vnode

Summary

PR: 288127

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jul 10 2025, 7:17 AM

Herald added subscribers: olce, imp. · View Herald TranscriptJul 10 2025, 7:17 AM

kib requested review of this revision.Jul 10 2025, 7:17 AM

kib added a reviewer: markj.Jul 10 2025, 8:16 AM

Thank you. I guess the problem arises when the directory is a mount point, and we need to upgrade the lock?

This revision is now accepted and ready to land.Jul 10 2025, 12:48 PM

In D51233#1169810, @markj wrote:

Thank you. I guess the problem arises when the directory is a mount point, and we need to upgrade the lock?

For zfs, most likely it was a walk over the snapshot.
But it is generic rule that namei(9) must not be called while owning any vnode lock or busy reference on a mp. For instance, another reason might be non-shared locked fs, or non-recursive vnode lock.
As I noted in my mail to the list, the patch was a guess.

Closed by commit rG63389aea24f1: inotify: do not call into namei() with a locked vnode (authored by kib). · Explain WhyJul 10 2025, 2:36 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG63389aea24f1: inotify: do not call into namei() with a locked vnode.

markj added a commit: rGe8c54222acdb: inotify: do not call into namei() with a locked vnode.Wed, Aug 5, 3:17 PM