libc: only append exterr herald and text if exterr was recorded
ClosedPublic
Actions

Authored by kib on Jul 8 2025, 2:05 PM.

Tags

None

Referenced Files

	F158053172: D51204.id158158.diff
	Wed, May 27, 11:59 PM

	Unknown Object (File)
	Mon, May 18, 9:39 AM

	Unknown Object (File)
	Mon, May 18, 1:39 AM

	Unknown Object (File)
	Sun, May 17, 9:12 PM

	Unknown Object (File)
	Sat, May 16, 7:33 PM

	Unknown Object (File)
	Sat, May 16, 7:33 PM

	Unknown Object (File)
	Sat, May 16, 7:32 PM

	Unknown Object (File)
	Fri, May 15, 9:22 AM

View All 70 Files

Subscribers

imp

Details

Reviewers

markj
asomers
brooks

Commits

rG72c848089f3b: libc: only append exterr herald and text if exterr was recorded

Summary

__uexterr_format: return empty string on no error, instead of "No error"
err(): check for the first symbol of the exterr to decide if there is
anything to print.

Requested by:   markj

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jul 8 2025, 2:05 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 8 2025, 2:05 PM

kib requested review of this revision.Jul 8 2025, 2:05 PM

markj accepted this revision.Jul 8 2025, 3:45 PM

This revision is now accepted and ready to land.Jul 8 2025, 3:45 PM

I verified that the test failures are gone now, thank you.

Closed by commit rG72c848089f3b: libc: only append exterr herald and text if exterr was recorded (authored by kib). · Explain WhyJul 8 2025, 3:56 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG72c848089f3b: libc: only append exterr herald and text if exterr was recorded.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

err.c

2 lines

uexterr_format.c

2 lines

Diff 158169

View Options

lib/libc/gen/err.c