amd64 pmap: convert some panics to KASSERTs
ClosedPublic
Actions

Authored by alc on Jul 6 2025, 5:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 4, 10:17 AM

	Unknown Object (File)
	Fri, Sep 25, 10:49 AM

	Unknown Object (File)
	Fri, Sep 25, 10:49 AM

	Unknown Object (File)
	Fri, Sep 18, 8:04 PM

	Unknown Object (File)
	Sat, Sep 12, 11:37 AM

	Unknown Object (File)
	Sep 9 2026, 10:16 AM

	Unknown Object (File)
	Sep 8 2026, 11:18 AM

	Unknown Object (File)
	Sep 6 2026, 7:31 PM

View All Files

Subscribers

imp

Details

Reviewers

kib
markj

Commits

rG6a7761b4d27c: amd64 pmap: convert panics to KASSERTs

Summary

With the recent changes to pmap_demote_DMAP(), the calls to pmap_demote_pdpe() and pmap_demote_pde_mpte() should never fail.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc requested review of this revision.Jul 6 2025, 5:53 PM

alc created this revision.

kib accepted this revision.Jul 6 2025, 5:58 PM

This revision is now accepted and ready to land.Jul 6 2025, 5:58 PM

Should the pmap_demote_pde() in pmap_unwire() get the same treatment? As I understand, wire should saved the pt page in radix.

markj accepted this revision.Jul 6 2025, 6:40 PM

In D51180#1168328, @kib wrote:

Should the pmap_demote_pde() in pmap_unwire() get the same treatment? As I understand, wire should saved the pt page in radix.

I think that should be preceded by the changes under discussion in D49442.

Closed by commit rG6a7761b4d27c: amd64 pmap: convert panics to KASSERTs (authored by alc). · Explain WhyJul 7 2025, 12:07 AM

This revision was automatically updated to reflect the committed changes.

alc added a commit: rG6a7761b4d27c: amd64 pmap: convert panics to KASSERTs.

Herald added a subscriber: imp. · View Herald TranscriptJul 7 2025, 12:07 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

pmap.c

12 lines

Diff 158076

View Options

amd64 pmap: convert some panics to KASSERTsClosedPublicActions