bhyve: Compile some device models only on amd64
ClosedPublic
Actions

Authored by markj on Jun 23 2023, 10:03 PM.

Details

Reviewers

jhb
corvink

Group Reviewers

bhyve

Commits

rG4e509e693f32: bhyve: Compile some device models only on amd64
rG71cc76e8d78e: bhyve: Compile some device models only on amd64

Summary

These models register legacy PCI interrupts, which won't be supported in
the arm64 port. In principle it should be possible to make these models
work on arm64 with a bit of effort, so don't move the sources to the
amd64 subdirectory.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 23 2023, 10:03 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJun 23 2023, 10:03 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Jun 23 2023, 10:03 PM

markj added a parent revision: D40737: bhyve: Move AP startup code to amd64/.

markj added a child revision: D40739: bhyve: Move legacy PCI interrupt handling under amd64/.

Harbormaster completed remote builds in B52272: Diff 123702.Jun 23 2023, 10:03 PM

corvink accepted this revision.Jun 26 2023, 6:05 AM

This revision is now accepted and ready to land.Jun 26 2023, 6:05 AM

jhb accepted this revision.Jun 27 2023, 7:07 PM

jhb added inline comments.

usr.sbin/bhyve/amd64/Makefile.inc
13	I kind of feel like this one might be x86 specific, though I think it's also QEMU specific?

markj added a subscriber: andrew.Jul 5 2023, 2:09 PM

markj added inline comments.

usr.sbin/bhyve/amd64/Makefile.inc
13	pctestdev? As I understand it's used to support KVM unit tests. Currently it's amd64-specific since it registers an I/O port space but I think it might be used for an arm64 port of the same tests? I think @andrew would know more.