Page MenuHomeFreeBSD
Differential D40986

bhyve: Make gdb support optional
ClosedPublic
Actions

Authored by markj on Jul 12 2023, 1:51 PM.
Tags
None
Referenced Files
F176022951: D40986.id128249.diff
Thu, Oct 15, 9:23 AM
Unknown Object (File)
Sat, Oct 10, 11:32 PM
Unknown Object (File)
Sat, Oct 10, 10:52 PM
Unknown Object (File)
Sat, Oct 10, 2:34 AM
Unknown Object (File)
Sat, Oct 10, 1:08 AM
Unknown Object (File)
Fri, Oct 9, 7:29 PM
Unknown Object (File)
Fri, Oct 9, 4:16 PM
Unknown Object (File)
Fri, Oct 9, 3:56 PM
View All Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
corvink
andrew
Group Reviewers
bhyve
Commits
rG7ed39a5ad79f: bhyve: Make gdb support optional
rGca2cda98d265: bhyve: Make gdb support optional
Summary

Add a BHYVE_GDB_SUPPORT make variable that can be set by per-arch
makefiles. When set, BHYVE_GDB is defined and can be used as a
preprocessor predicate. Use it to guard gdb stub calls in MI code.

The arm64 bhyve port currently does not have a functional gdb stub, but
that's not critical to landing the port, so this mechanism slightly
reduces the friction of adding support for a new platform.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jul 12 2023, 1:51 PM
Herald added a reviewer: bhyve. · View Herald TranscriptJul 12 2023, 1:51 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
markj requested review of this revision.Jul 12 2023, 1:51 PM
Harbormaster completed remote builds in B52579: Diff 124548.Jul 12 2023, 1:51 PM
markj added a child revision: D40987: bhyve: Move vcpu initialization into a MD source file.Jul 12 2023, 1:51 PM
markj added a parent revision: D40741: bhyve: Make most I/O port handling specific to amd64.Jul 12 2023, 1:52 PM
jhb accepted this revision.Jul 12 2023, 6:33 PM
jhb added inline comments.
usr.sbin/bhyve/bhyverun.c
149

Do you want to make '-G' here conditional on BHYVE_GDB? (Not sure how messy the usage() function ends up at the end of all this)

This revision is now accepted and ready to land.Jul 12 2023, 6:33 PM
corvink accepted this revision.Jul 13 2023, 5:34 AM
Closed by commit rGca2cda98d265: bhyve: Make gdb support optional (authored by markj). · Explain WhyOct 4 2023, 4:54 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGca2cda98d265: bhyve: Make gdb support optional.
markj added a commit: rG7ed39a5ad79f: bhyve: Make gdb support optional.Oct 11 2023, 1:25 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
13 lines
amd64/
2 lines
10 lines

Diff 128249

View Options

usr.sbin/bhyve/Makefile

Loading...
View Options

usr.sbin/bhyve/amd64/Makefile.inc

Loading...
View Options

usr.sbin/bhyve/bhyverun.c

Loading...