Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 54209 Build 51099: arc lint + arc unit
Event Timeline
Also need an update to tools/build/options/WITHOUT_BHYVE it looks like
I'm not sure why bhyve was done the way it was though, rather than having MK_BHYVE default be set based on arch.
I still have a couple of WIP patches: one to update the bhyve man page a bit, and another to update option parsing and usage strings. There are quite a few further TODOs: gdb support, PCI passthrough support, ACPI support. I've started working on the gdb stub in the background.
I still have a couple of WIP patches: one to update the bhyve man page a bit, and another to update option parsing and usage strings.
Yeah, I assumed this change will go in towards the end of the series, but it looks good to me when you're ready to push it.
The change to usr.sbin/Makefile.aarch64 no longer applies following commit 773606fcdfae00a3f850bcd39969a63d9a8fb129.
I'm probably missing something since I'm just catching up with this work, but 'make buildworld' fails in usr.sbin/bhyve:
===> usr.sbin/bhyve (includes) make[4]: "/home/bcran/src/usr.sbin/bhyve/Makefile" line 68: Could not find aarch64/Makefile.inc make[4]: Fatal errors encountered -- cannot continue make[4]: stopped in /home/bcran/src/usr.sbin/bhyve
I've just applied the latest version of this patch but it's still looking for aarch64/Makefile.inc both during a "make buildworld" and a "make" in usr.sbin/bhyve on my Ampere system:
bcran@gluon:~/src/freebsd/usr.sbin/bhyve % make make: "/home/bcran/src/freebsd/usr.sbin/bhyve/Makefile" line 68: Could not find aarch64/Makefile.inc make: Fatal errors encountered -- cannot continue make: stopped in /home/bcran/src/freebsd/usr.sbin/bhyve
This is just one patch of a few that are required: see the "stack" tab. The full patch series is available at https://github.com/markjdb/freebsd/tree/bhyvearm64-upstream