Page MenuHomeFreeBSD

Reduce verbosity of the mrsas driver
AbandonedPublic

Authored by bcran on Jul 3 2021, 4:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 1:59 AM
Unknown Object (File)
Sun, Apr 21, 9:17 PM
Unknown Object (File)
Thu, Apr 11, 12:12 AM
Unknown Object (File)
Wed, Apr 10, 11:12 PM
Unknown Object (File)
Sat, Apr 6, 8:10 AM
Unknown Object (File)
Dec 22 2023, 11:24 PM
Unknown Object (File)
Dec 12 2023, 8:55 PM
Unknown Object (File)
Nov 10 2023, 7:41 PM
Subscribers

Details

Summary

I expect this is just a starting point for further discussion.
The mrsas driver appears to me to be excessively verbose, so I've made an initial patch to move some of the lines that appear more to be debugging under MRSAS_INFO and MRSAS_TRACE.

This patch reduces the default logging level, and moves several
print statements under mrsas_dprint.

Before:

AVAGO MegaRAID SAS FreeBSD mrsas driver version: 07.709.04.00-fbsd
mrsas0: <BROADCOM AERO-10E2 SAS Controller> port 0x2000-0x20ff mem 0x9e400000-0x9e4fffff,0x9e500000-0x9e5fffff,0x9ea00000-0x9eafffff at 
device 0.0 numa-domain 0 on pci1
mrsas0: FW now in Ready state
mrsas0: Using MSI-X with 128 number of vectors
mrsas0: FW supports <128> MSIX vector,Online CPU 256 Current MSIX <128>
mrsas0: mrsas_init_adapter: sc->reply_q_depth 0x27e0,sc->request_alloc_sz 0x9f60, sc->reply_alloc_sz 0x13f00,sc->io_frames_alloc_sz 0x13ee00
mrsas0: max sge: 0x106, max chain frame size: 0x1000, max fw cmd: 0x13ec sc->chain_frames_alloc_sz: 0x13ec000
mrsas0: Issuing IOC INIT command to FW.
mrsas0: IOC INIT response received from FW.
mrsas0: FW supports atomic descriptor: Yes
mrsas0: NVME page size     : (4096)
mrsas0: FW supports JBOD Map 
mrsas0: FW supports JBOD Map Ext 
mrsas0: Jbod map is supported
mrsas0: VD created target ID: 0xef
mrsas0: FW supports: UnevenSpanSupport=1
mrsas0: max_fw_cmds: 5100  max_scsi_cmds: 5084
mrsas0: MSI-x interrupts setup success
mrsas0: mrsas_ocr_thread

After:

Broadcom MegaRAID SAS mrsas driver version: 07.709.04.00-fbsd
mrsas0: <BROADCOM AERO-10E2 SAS Controller> port 0x2000-0x20ff mem 0x9e400000-0x9e4fffff,0x9e500000-0x9e5fffff,0x9ea00000-0x9eafffff at device 0.0 numa-domain 3 on pci1
mrsas0: Using MSI-X with 128 vectors
mrsas0: NVME page size: 4096
mrsas0: FW supports JBOD Map
mrsas0: FW supports JBOD Map Ext
mrsas0: FW supports: UnevenSpanSupport=1
mrsas0: max_fw_cmds: 5100  max_scsi_cmds: 5084

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40250
Build 37139: arc lint + arc unit

Event Timeline

bcran requested review of this revision.Jul 3 2021, 4:36 AM
bcran retitled this revision from Reduce verbosity of the mrsas driver I expect this is just a starting point for further discussion. The mrsas driver appears to me to be excessively verbose, so I've made an initial patch to move some of the lines that appear more to be debugging... to Reduce verbosity of the mrsas driver.Jul 3 2021, 4:37 AM
bcran edited the summary of this revision. (Show Details)
bcran edited the summary of this revision. (Show Details)

Hi Rebecca,

I think it's better not to suppress/put under debug flag driver load time prints e.g. controller transition to ready, sending ioc init etc. These prints are important ones.
Infact, I don't see these prints as really debug but information prints.
Moreover, these prints will be logged during driver load only. So I would like to keep them as it is.

Thanks,
Sumit