Page MenuHomeFreeBSD
Feed Advanced Search

Apr 21 2020

bcran commandeered D19976: bhyve: Support a _VARS.fd file for bootrom.

@scottph has indicated he no longer has the time/interest in working on this, so I'll take over and work to get it committed.

Apr 21 2020, 11:59 PM

Apr 8 2020

bcran accepted D24300: Bhyve: SMBIOS bcdrev calculated from major/minor values.
Apr 8 2020, 3:24 AM

Apr 6 2020

bcran added a comment to D24066: bhyve: support relocating fbuf and passthru data BARs.

Is this with PcdPciDisableBusEnumeration = TRUE in UEFI ?

Apr 6 2020, 2:57 AM · bhyve

Apr 5 2020

bcran added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.
In D19976#515732, @mat wrote:

Has this been committed yet?

Apr 5 2020, 6:55 PM
bcran added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

@scottph Are you still interested in working on this?

Apr 5 2020, 6:54 PM
bcran added a comment to D24066: bhyve: support relocating fbuf and passthru data BARs.
Apr 5 2020, 5:54 PM · bhyve
bcran accepted D24300: Bhyve: SMBIOS bcdrev calculated from major/minor values.
Apr 5 2020, 5:51 PM
bcran accepted D24276: ci-qemu-test.sh: use pkgbase.

Works great here.

Apr 5 2020, 4:32 AM

Mar 31 2020

bcran committed rS359478: Bhyve: fix SMBIOS Type 17 table generation.
Bhyve: fix SMBIOS Type 17 table generation
Mar 31 2020, 2:37 AM
bcran closed D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 31 2020, 2:37 AM

Mar 30 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 10:13 PM
bcran updated the summary of D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 8:05 PM
bcran updated the test plan for D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 8:05 PM
bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 8:00 PM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Change comments to C style.
Mar 30 2020, 8:00 PM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

@rgrimes Could you approve the latest patch, or provide comments on what should be changed please?

Mar 30 2020, 7:57 PM

Mar 29 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 29 2020, 3:56 PM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.

Upload the full patch.

Mar 29 2020, 3:55 PM

Mar 28 2020

bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Change overflow error to a warning and truncate type 17 memory size.
Mar 28 2020, 11:33 PM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

There is no need to error out on overflow here. The type17 isn't used by most o/s's for determining how much memory is available: there is e820, the EFI memory map, etc etc. Perhaps print an error in bhyve, buit there doesn't seem any point in erroring out.

Mar 28 2020, 11:27 PM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Rework type17 generation and error out on overflow.
Mar 28 2020, 4:53 PM
bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 28 2020, 4:52 AM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Revert bumping the SMBIOS version.
Mar 28 2020, 4:45 AM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Fixes based on review feedback.
Mar 28 2020, 4:42 AM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.
In D24107#532393, @jhb wrote:

That is what the 0x7fff value is for when using extended btw, is to report the max possible size for legacy systems. I agree that we should use the non-extended size when it fits.

Mar 28 2020, 4:19 AM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.
In D24107#532391, @jhb wrote:

Rebecca is it ok with you if I go create a review to do the bcdrev fix?

Mar 28 2020, 3:14 AM

Mar 27 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 27 2020, 12:15 AM

Mar 26 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 26 2020, 11:57 PM
bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 26 2020, 11:36 PM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

This calculation seems odd, I see later it is overwritten for large memory, cant we just continue to use extended all the time and leave this set at 0x7fff? Never mind, spec says not. Ok how about doing:

Mar 26 2020, 11:34 PM

Mar 20 2020

bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

You might want to see what happens with > 64GB (or maybe 128GB, can't recall the value). At some point additional tables are required for Windows.

Mar 20 2020, 5:57 PM

Mar 18 2020

bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 18 2020, 6:55 PM
bcran committed rS359065: Bhyve: log message when rfb client connects.
Bhyve: log message when rfb client connects
Mar 18 2020, 3:17 AM
bcran closed D24098: Bhyve: log message when rfb client connects.
Mar 18 2020, 3:17 AM
bcran committed rS359064: Bhyve: DPRINTF already includes newline, so don't add another.
Bhyve: DPRINTF already includes newline, so don't add another
Mar 18 2020, 3:16 AM
bcran closed D24099: Bhyve: DPRINTF already includes newline, so don't add another.
Mar 18 2020, 3:16 AM
bcran committed rS359063: ath_hal: fix typo in ath_hal_printf.
ath_hal: fix typo in ath_hal_printf
Mar 18 2020, 3:14 AM
bcran retitled D24107: Bhyve: fix SMBIOS Type 17 table generation from Bhyve: log message when rfb client connects to Bhyve: fix SMBIOS Type 17 table generation.
Mar 18 2020, 2:14 AM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.

Remove unrelated changes.

Mar 18 2020, 2:13 AM
bcran created D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 18 2020, 2:13 AM

Mar 17 2020

bcran added reviewers for D24099: Bhyve: DPRINTF already includes newline, so don't add another: jhb, vmaffione, emaste, seanc, allanjude, imp.
Mar 17 2020, 5:52 PM
bcran created D24099: Bhyve: DPRINTF already includes newline, so don't add another.
Mar 17 2020, 3:16 PM
bcran created D24098: Bhyve: log message when rfb client connects.
Mar 17 2020, 3:11 PM

Feb 20 2020

bcran committed rS358183: dtc: remove unknown option printf, since getopt will print it.
dtc: remove unknown option printf, since getopt will print it
Feb 20 2020, 9:30 PM
bcran closed D23662: dtc: remove unknown option printf, since getopt will print it.
Feb 20 2020, 9:30 PM

Feb 15 2020

bcran added a comment to D23662: dtc: remove unknown option printf, since getopt will print it.

This looks fine, but please submit it as a GitHub PR so that it goes through CI (I can't imagine it failing).

Feb 15 2020, 7:04 PM

Feb 13 2020

bcran retitled D23662: dtc: remove unknown option printf, since getopt will print it from dtc: unknown getopt option character is in optopt, not ch to dtc: remove unknown option printf, since getopt will print it.
Feb 13 2020, 6:41 PM
bcran updated the diff for D23662: dtc: remove unknown option printf, since getopt will print it.

Remove the print statement in the default handler.

Feb 13 2020, 6:41 PM
bcran added a comment to D23662: dtc: remove unknown option printf, since getopt will print it.

change should also go here: https://github.com/davidchisnall/dtc

Feb 13 2020, 4:22 PM
bcran created D23662: dtc: remove unknown option printf, since getopt will print it.
Feb 13 2020, 4:03 PM

Feb 8 2020

bcran committed rP525557: Revert "sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel".
Revert "sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel"
Feb 8 2020, 2:55 PM

Feb 7 2020

bcran closed D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

Committed in https://svnweb.freebsd.org/ports?view=revision&revision=525460 .

Feb 7 2020, 6:23 AM
bcran committed rP525460: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel.
sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel
Feb 7 2020, 4:44 AM
bcran closed D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".
Feb 7 2020, 2:55 AM
bcran committed rP525458: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".
sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}"
Feb 7 2020, 2:55 AM

Feb 6 2020

bcran added a comment to D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

@araujo Could you approve my latest changes please? I ran poudriere and put the successful results at:

Feb 6 2020, 4:41 PM
bcran added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

OK, as soon as the poudriere get the results, share it here.

Feb 6 2020, 7:28 AM
bcran updated the test plan for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
Feb 6 2020, 7:28 AM
bcran added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

Did you test it using poudriere?

Feb 6 2020, 6:27 AM
bcran added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
In D23476#516323, @mat wrote:

Fine by me.

Feb 6 2020, 5:16 AM

Feb 5 2020

bcran retitled D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}" from sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}" and use ${WRKSRC} consistently. to sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".
Feb 5 2020, 7:58 AM
bcran updated the diff for D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

Simplify change to just the PYTHON_CMD fix.

Feb 5 2020, 7:44 AM
bcran added a comment to D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

How are you testing these changes that you didn't catch this problem before?

Feb 5 2020, 3:03 AM

Feb 4 2020

bcran added a comment to D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

And I know there are several problems with the Makefile, which I've learned through my updates to the uefi-edk2-bhyve port. But I'd like to get this fix committed and then, once the changes to uefi-edk2-bhyve are committed I'll fix the issues with this port based on what I've learned.

Feb 4 2020, 10:00 PM
bcran added a comment to D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

Unfortunately this has broken the port for anyone without python 2.7 installed. Could somebody approve me to commit this fix please?
@araujo @mat ?

Feb 4 2020, 9:59 PM
bcran added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

Thanks for the feedback, and sorry about all the mistakes!

Feb 4 2020, 4:19 PM
bcran added inline comments to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
Feb 4 2020, 4:17 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Fix some more issues from the review feedback.
Feb 4 2020, 4:17 PM

Feb 3 2020

bcran added inline comments to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
Feb 3 2020, 10:10 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • MAKE_ARGS should be earlier in the Makefile
Feb 3 2020, 10:10 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Fix variables ordering
Feb 3 2020, 10:06 PM
bcran retitled D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}" from Replace "python2.7" with "${PYTHON_CMD}" and use ${WRKSRC} consistently. to sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}" and use ${WRKSRC} consistently..
Feb 3 2020, 5:21 PM
bcran created D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".
Feb 3 2020, 5:21 PM
bcran added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

@mat I've updated the Makefile to be similar to sysutils/uefi-edk2-qemu - which involved removing BASH_CMD (replacing it with just 'bash'), removing USE_GCC and some other changes. I'd appreciate feedback about whether these changes are better or worse!

Feb 3 2020, 5:07 PM
bcran added inline comments to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
Feb 3 2020, 5:04 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Move DEBUG_VARS, DEBUG_VARS_OFF and HTTP_BOOT_VARS to before OPTIONS
Feb 3 2020, 5:03 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Remove sysutils/uefi-edk2-bhyve-devel from sysutils/Makefile
Feb 3 2020, 5:01 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Update port Makefile to be similar in style to uefi-edk2-qemu
Feb 3 2020, 5:00 PM
bcran committed rP525010: sysutils/uefi-edk2-qemu: update to edk2-stable201911.
sysutils/uefi-edk2-qemu: update to edk2-stable201911
Feb 3 2020, 4:57 AM
bcran closed D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.
Feb 3 2020, 4:57 AM
bcran added a comment to D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

If you will remove the port, why botter to update it and trigger hooks around to rebuild the package?

Focus here, if your intention is to remove the package: https://reviews.freebsd.org/D23476

Feb 3 2020, 3:32 AM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Update MOVED to show that uefi-edk2-bhyve-devel is now uefi-edk2-bhyve
Feb 3 2020, 3:11 AM
bcran created D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
Feb 3 2020, 3:07 AM
bcran added a comment to D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

Could a ports committer commit this for me, please?

Feb 3 2020, 2:38 AM

Feb 2 2020

bcran added a member for Src Committers: bcran.
Feb 2 2020, 8:58 PM
bcran added inline comments to D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.
Feb 2 2020, 5:51 PM
bcran updated the diff for D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

Remove PORTREVISION.

Feb 2 2020, 5:50 PM
bcran updated the diff for D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

Revert unrelated change to sysutils/uefi-edk2-bhyve port

Feb 2 2020, 2:40 AM
bcran created D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.
Feb 2 2020, 2:38 AM

Jan 17 2020

bcran accepted D23232: Fix regression in bsdinstall post r356740 - partedit errno(2) 21 EISDIR.
Jan 17 2020, 7:42 PM

Jan 15 2020

bcran closed D22979: bsdinstall: Use TMPDIR if set.

Fixed in r356740 (https://svnweb.freebsd.org/base?view=revision&revision=356740).

Jan 15 2020, 12:54 AM
bcran committed rS356740: bsdinstall: Use TMPDIR if set.
bsdinstall: Use TMPDIR if set
Jan 15 2020, 12:45 AM

Jan 14 2020

bcran added a comment to D22979: bsdinstall: Use TMPDIR if set.
In D22979#507973, @ryan_freqlabs.com wrote:

Thank you! :)

Jan 14 2020, 5:55 PM

Jan 6 2020

bcran added a comment to D22979: bsdinstall: Use TMPDIR if set.
In D22979#504080, @ryan_freqlabs.com wrote:

@bcran Thanks! Would you mind committing this for me? I don't have the bit.

Jan 6 2020, 4:06 PM

Jan 2 2020

bcran accepted D22979: bsdinstall: Use TMPDIR if set.
Jan 2 2020, 3:05 AM

Nov 19 2019

bcran accepted D22432: Add --esp/-E argument to print the currently booted ESP.
Nov 19 2019, 12:24 AM

Oct 17 2019

bcran accepted D22062: Allow loader.efi to identify non-standard boot setup.
Oct 17 2019, 8:31 PM
bcran added a comment to D22062: Allow loader.efi to identify non-standard boot setup.
Oct 17 2019, 8:19 PM

Oct 9 2019

bcran accepted D21930: fix ESP generation for ZFS boot.
Oct 9 2019, 1:39 AM

Sep 27 2019

bcran committed rS352788: MFC r344839:.
MFC r344839:
Sep 27 2019, 5:12 AM