Page MenuHomeFreeBSD

stand: Fix defaults file
ClosedPublic

Authored by imp on Oct 19 2024, 6:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 3:04 AM
Unknown Object (File)
Fri, Nov 29, 8:42 AM
Unknown Object (File)
Nov 8 2024, 12:50 AM
Unknown Object (File)
Nov 7 2024, 2:49 AM
Unknown Object (File)
Nov 7 2024, 2:35 AM
Unknown Object (File)
Nov 7 2024, 12:37 AM
Unknown Object (File)
Nov 2 2024, 5:38 AM
Unknown Object (File)
Nov 1 2024, 6:45 AM
Subscribers

Details

Summary

Currently, quotes in a comment lead to mal-formed lines warnings. Remove
the quotes since it doesn't matter. The underlying bug likely should be
fixed, but since stability week is neigh, workaround this.

Fixes: 7df3e400ea687
Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Oct 19 2024, 6:17 PM
This revision is now accepted and ready to land.Oct 19 2024, 6:20 PM
This revision was automatically updated to reflect the committed changes.

I suspect this is sufficient to fix the underlying problem:

diff --git a/stand/lua/config.lua b/stand/lua/config.lua
index 86f5ef6174a2..bcf418cfca88 100644
--- a/stand/lua/config.lua
+++ b/stand/lua/config.lua
@@ -65,7 +65,7 @@ local MSG_FAILSYN_BADVAR = "Malformed variable expression at position '%d'"
 -- env_var entries in the pattern table.  This is perhaps a good target for a
 -- little refactoring.
 local MODULEEXPR = '([%w%d-_.]+)'
-local QVALEXPR = '"(.*)"'
+local QVALEXPR = '"([^#]*)"'
 local QVALREPL = QVALEXPR:gsub('%%', '%%%%')
 local WORDEXPR = "([-%w%d][-%w%d_.]*)"
 local WORDREPL = WORDEXPR:gsub('%%', '%%%%')

I suspect this is sufficient to fix the underlying problem:

diff --git a/stand/lua/config.lua b/stand/lua/config.lua
index 86f5ef6174a2..bcf418cfca88 100644
--- a/stand/lua/config.lua
+++ b/stand/lua/config.lua
@@ -65,7 +65,7 @@ local MSG_FAILSYN_BADVAR = "Malformed variable expression at position '%d'"
 -- env_var entries in the pattern table.  This is perhaps a good target for a
 -- little refactoring.
 local MODULEEXPR = '([%w%d-_.]+)'
-local QVALEXPR = '"(.*)"'
+local QVALEXPR = '"([^#]*)"'
 local QVALREPL = QVALEXPR:gsub('%%', '%%%%')
 local WORDEXPR = "([-%w%d][-%w%d_.]*)"
 local WORDREPL = WORDEXPR:gsub('%%', '%%%%')

nope. ignore that.