Page MenuHomeFreeBSD
Differential D29254

sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building
ClosedPublic
Actions

Authored by bcran on Mar 14 2021, 5:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 12:54 PM
Unknown Object (File)
Mon, Dec 9, 4:02 AM
Unknown Object (File)
Thu, Dec 5, 5:10 PM
Unknown Object (File)
Thu, Dec 5, 5:06 PM
Unknown Object (File)
Thu, Dec 5, 5:06 PM
Unknown Object (File)
Thu, Dec 5, 5:06 PM
Unknown Object (File)
Thu, Dec 5, 4:55 PM
Unknown Object (File)
Nov 16 2024, 7:01 AM
View All 95 Files
Subscribers
mat

Details

Reviewers
grehan
woodsb02
tsoome
manu
Group Reviewers
bhyve
Commits
rP569373: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building
Summary

gcc48 is only required during building, and is not a runtime
dependency.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bcran created this revision.Mar 14 2021, 5:34 AM
Herald added a subscriber: mat. · View Herald TranscriptMar 14 2021, 5:34 AM
Harbormaster completed remote builds in B37822: Diff 85708.Mar 14 2021, 5:34 AM
bcran requested review of this revision.Mar 14 2021, 5:34 AM
bcran added a reviewer: bhyve.Mar 14 2021, 5:36 AM
bcran added a comment.Mar 16 2021, 4:03 AM

@woodsb02 Could you review and approve this for me, please?

manu accepted this revision.Mar 16 2021, 5:58 AM

Is the 4.8 version required for something ? Otherwise depending on lang/gcc would be better (not really sure if we have some way to do that).

This revision is now accepted and ready to land.Mar 16 2021, 5:58 AM
bcran added a comment.Mar 16 2021, 12:03 PM
In D29254#655711, @manu wrote:

Is the 4.8 version required for something ? Otherwise depending on lang/gcc would be better (not really sure if we have some way to do that).

Unfortunately this ancient UDK2014.SP1 code only builds with gcc 4.8. If we decide to keep it around, we should get it building with a newer version.

manu added a comment.Mar 17 2021, 7:19 AM
In D29254#655831, @bcran wrote:
In D29254#655711, @manu wrote:

Is the 4.8 version required for something ? Otherwise depending on lang/gcc would be better (not really sure if we have some way to do that).

Unfortunately this ancient UDK2014.SP1 code only builds with gcc 4.8. If we decide to keep it around, we should get it building with a newer version.

OK I see. Well for now just have a build time dep is better then.
Go ahead and commit this.

grehan added a comment.Mar 17 2021, 7:41 AM

The older bhyve edk2 f/w can be built with up to gcc7, if gcc48 needs to be killed off

(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222233#c7)
bcran updated this revision to Diff 86089.Mar 20 2021, 10:24 PM

We'll also need to update the port revision.

This revision now requires review to proceed.Mar 20 2021, 10:24 PM
Harbormaster completed remote builds in B37968: Diff 86089.Mar 20 2021, 10:24 PM
bcran added a comment.Mar 20 2021, 10:24 PM
In D29254#656248, @manu wrote:

OK I see. Well for now just have a build time dep is better then.
Go ahead and commit this.

Thanks. Unfortunately I made a silly mistake and forgot to bump the PORTREVISION.

bcran added a comment.Mar 24 2021, 7:58 PM

@manu Sorry, could you re-approve the change please?

manu accepted this revision.Mar 24 2021, 8:01 PM

done :)

This revision is now accepted and ready to land.Mar 24 2021, 8:01 PM
tsoome accepted this revision.Mar 24 2021, 8:30 PM
Closed by commit rP569373: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building (authored by bcran). · Explain WhyMar 28 2021, 4:43 AM
This revision was automatically updated to reflect the committed changes.
bcran added a commit: rP569373: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.

Revision Contents
Changeset List

PathSize
head/
sysutils/
uefi-edk2-bhyve-csm/
4 lines

Diff 86426

View Options

head/sysutils/uefi-edk2-bhyve-csm/Makefile

Loading...