Page MenuHomeFreeBSD

sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building
ClosedPublic

Authored by bcran on Mar 14 2021, 5:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 11:51 AM
Unknown Object (File)
Mar 10 2024, 6:31 AM
Unknown Object (File)
Mar 10 2024, 6:31 AM
Unknown Object (File)
Mar 10 2024, 6:31 AM
Unknown Object (File)
Mar 10 2024, 6:31 AM
Unknown Object (File)
Mar 6 2024, 9:16 PM
Unknown Object (File)
Jan 10 2024, 9:16 AM
Unknown Object (File)
Dec 28 2023, 4:38 AM
Subscribers

Details

Summary

gcc48 is only required during building, and is not a runtime
dependency.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bcran requested review of this revision.Mar 14 2021, 5:34 AM

@woodsb02 Could you review and approve this for me, please?

Is the 4.8 version required for something ? Otherwise depending on lang/gcc would be better (not really sure if we have some way to do that).

This revision is now accepted and ready to land.Mar 16 2021, 5:58 AM
In D29254#655711, @manu wrote:

Is the 4.8 version required for something ? Otherwise depending on lang/gcc would be better (not really sure if we have some way to do that).

Unfortunately this ancient UDK2014.SP1 code only builds with gcc 4.8. If we decide to keep it around, we should get it building with a newer version.

In D29254#655711, @manu wrote:

Is the 4.8 version required for something ? Otherwise depending on lang/gcc would be better (not really sure if we have some way to do that).

Unfortunately this ancient UDK2014.SP1 code only builds with gcc 4.8. If we decide to keep it around, we should get it building with a newer version.

OK I see. Well for now just have a build time dep is better then.
Go ahead and commit this.

The older bhyve edk2 f/w can be built with up to gcc7, if gcc48 needs to be killed off

(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222233#c7)

We'll also need to update the port revision.

This revision now requires review to proceed.Mar 20 2021, 10:24 PM
In D29254#656248, @manu wrote:

OK I see. Well for now just have a build time dep is better then.
Go ahead and commit this.

Thanks. Unfortunately I made a silly mistake and forgot to bump the PORTREVISION.

@manu Sorry, could you re-approve the change please?

This revision is now accepted and ready to land.Mar 24 2021, 8:01 PM